Merge pull request #172 from wp-cli/fix/suppress-errors-during-unserialize

schlessera · web-flow · commit 7743775a09f6 · 2022-08-26T00:10:20.000+01:00
Add further suppression of warnings and notices
diff --git a/src/WP_CLI/SearchReplacer.php b/src/WP_CLI/SearchReplacer.php
@@ -83,7 +83,13 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis
 				}
 			}
 
+			// The error suppression operator is not enough in some cases, so we disable
+			// reporting of notices and warnings as well.
+			$error_reporting = error_reporting();
+			error_reporting( $error_reporting & ~E_NOTICE & ~E_WARNING );
 			$unserialized = is_string( $data ) ? @unserialize( $data ) : false;
+			error_reporting( $error_reporting );
+
 			if ( false !== $unserialized ) {
 				$data = $this->run_recursively( $unserialized, true, $recursion_level + 1 );
 			} elseif ( is_array( $data ) ) {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,13 @@ private function run_recursively( $data, $serialised, $recursion_level = 0, $vis`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`
	`86`	`+ // The error suppression operator is not enough in some cases, so we disable`
	`87`	`+ // reporting of notices and warnings as well.`
	`88`	`+ $error_reporting = error_reporting();`
	`89`	`+ error_reporting( $error_reporting & ~E_NOTICE & ~E_WARNING );`
`86`	`90`	`$unserialized = is_string( $data ) ? @unserialize( $data ) : false;`
	`91`	`+ error_reporting( $error_reporting );`
	`92`	`+`
`87`	`93`	`if ( false !== $unserialized ) {`
`88`	`94`	`$data = $this->run_recursively( $unserialized, true, $recursion_level + 1 );`
`89`	`95`	`} elseif ( is_array( $data ) ) {`