Install WP-CLI for tests via composer global require

Doing so makes `utils/make-phar.php` available to the test suite.

Because WP-CLI will come with Behat, it's not longer necessary to
install via `install-package-tests.sh` or the package's dependencies.

Author: danielbachhuber

.travis.yml

@@ -17,7 +17,8 @@ cache:
 
 env:
   global:
-    - WP_CLI_BIN_DIR=/tmp/wp-cli-phar
+    - PATH="$HOME/.composer/vendor/bin:$PATH"
+    - WP_CLI_BIN_DIR=$HOME/.composer/vendor/bin
 
 matrix:
   include:
@@ -32,9 +33,14 @@ matrix:
     - php: 5.3
       env: WP_VERSION=latest
 
-before_script:
+install:
   - phpenv config-rm xdebug.ini
-  - composer validate
+  - composer global require wp-cli/wp-cli
+  - composer install --no-dev
   - bash bin/install-package-tests.sh
 
-script: ./vendor/bin/behat --format progress --strict
+before_script:
+  - composer validate
+
+script:
+  - behat --format progress --strict

bin/install-package-tests.sh

@@ -2,39 +2,9 @@
 
 set -ex
 
-WP_CLI_BIN_DIR=${WP_CLI_BIN_DIR-/tmp/wp-cli-phar}
-
-PACKAGE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../ && pwd )"
-
-download() {
-    if [ `which curl` ]; then
-        curl -s "$1" > "$2";
-    elif [ `which wget` ]; then
-        wget -nv -O "$2" "$1"
-    fi
-}
-
-install_wp_cli() {
-
-	# the Behat test suite will pick up the executable found in $WP_CLI_BIN_DIR
-	mkdir -p $WP_CLI_BIN_DIR
-	download https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli-nightly.phar $WP_CLI_BIN_DIR/wp
-	chmod +x $WP_CLI_BIN_DIR/wp
-
-}
-
-download_behat() {
-
-	cd $PACKAGE_DIR
-	composer require --dev behat/behat='~2.5'
-
-}
-
 install_db() {
 	mysql -e 'CREATE DATABASE IF NOT EXISTS wp_cli_test;' -uroot
 	mysql -e 'GRANT ALL PRIVILEGES ON wp_cli_test.* TO "wp_cli_test"@"localhost" IDENTIFIED BY "password1"' -uroot
 }
 
-install_wp_cli
-download_behat
 install_db

circle.yml

@@ -2,7 +2,8 @@ machine:
   php:
     version: 5.6.22
   environment:
-    WP_CLI_BIN_DIR: /tmp/wp-cli-phar
+    PATH: "$HOME/.composer/vendor/bin:$PATH"
+    WP_CLI_BIN_DIR: "$HOME/.composer/vendor/bin"
 
 dependencies:
   cache_directories:
@@ -14,13 +15,15 @@ dependencies:
     - echo ""  > /opt/circleci/php/$(phpenv global)/etc/conf.d/xdebug.ini
     # Increase memory limit
     - echo "memory_limit = 512M" > /opt/circleci/php/$(phpenv global)/etc/conf.d/memory.ini
-
+  override:
+    - composer global require wp-cli/wp-cli
+    - composer install --no-dev
+    - bash bin/install-package-tests.sh
 
 test:
   pre:
     - composer validate
-    - bash bin/install-package-tests.sh
   override:
-    - WP_VERSION=latest ./vendor/bin/behat --format progress --strict
+    - WP_VERSION=latest behat --format progress --strict
     - rm -rf '/tmp/wp-cli-test core-download-cache'
-    - WP_VERSION=trunk ./vendor/bin/behat --format progress --strict
+    - WP_VERSION=trunk behat --format progress --strict