Merge pull request #139 from wp-cli/scaffold-github-templates

Scaffold GitHub issue and pull request templates by default

Author: gitlost

README.md

@@ -16,7 +16,7 @@ This package implements the following commands:
 Generate the files needed for a basic WP-CLI command.
 
 ~~~
-wp scaffold package <name> [--description=<description>] [--homepage=<homepage>] [--dir=<dir>] [--license=<license>] [--require_wp_cli=<version>] [--skip-tests] [--skip-readme] [--skip-install] [--force]
+wp scaffold package <name> [--description=<description>] [--homepage=<homepage>] [--dir=<dir>] [--license=<license>] [--require_wp_cli=<version>] [--skip-tests] [--skip-readme] [--skip-github] [--skip-install] [--force]
 ~~~
 
 Default behavior is to create the following files:
@@ -61,6 +61,9 @@ WP-CLI `packages/local/` directory.
 	[--skip-readme]
 		Don't generate a README.md for the package.
 
+	[--skip-github]
+		Don't generate GitHub issue and pull request templates.
+
 	[--skip-install]
 		Don't install the package after scaffolding.
 

features/scaffold-package-github.feature

@@ -30,7 +30,7 @@ Feature: Scaffold GitHub configuration for an existing package
     When I run `wp package path`
     Then save STDOUT as {PACKAGE_PATH}
 
-    When I run `wp scaffold package wp-cli/default-github`
+    When I run `wp scaffold package wp-cli/default-github --skip-github`
     Then the {PACKAGE_PATH}/local/wp-cli/default-github directory should exist
 
     When I run `wp scaffold package-github {PACKAGE_PATH}/local/wp-cli/default-github`

features/scaffold-package.feature

@@ -45,6 +45,8 @@ Feature: Scaffold WP-CLI commands
       """
     And the {PACKAGE_PATH}/local/wp-cli/foo/wp-cli.yml file should exist
     And the {PACKAGE_PATH}/local/wp-cli/foo/.travis.yml file should not exist
+    And the {PACKAGE_PATH}/local/wp-cli/foo/.github/PULL_REQUEST_TEMPLATE file should exist
+    And the {PACKAGE_PATH}/local/wp-cli/foo/.github/ISSUE_TEMPLATE file should exist
 
     When I run `wp --require={PACKAGE_PATH}/local/wp-cli/foo/command.php hello-world`
     Then STDOUT should be:
@@ -147,13 +149,13 @@ Feature: Scaffold WP-CLI commands
       s
       """
 
-    When I run `wp scaffold package wp-cli/same-package --skip-tests`
+    When I run `wp scaffold package wp-cli/same-package --skip-tests --skip-github`
     Then STDOUT should contain:
       """
       Success: Created package files
       """
 
-    When I run `wp scaffold package wp-cli/same-package --skip-tests < session`
+    When I run `wp scaffold package wp-cli/same-package --skip-tests --skip-github < session`
     And STDERR should contain:
       """
       Warning: File already exists
@@ -231,10 +233,13 @@ Feature: Scaffold WP-CLI commands
       """
     And the /tmp/wp-cli-home/foo directory should exist
 
-  Scenario: Scaffold a package but skip installation
+  Scenario: Scaffold a package but skip installation and GitHub templates
     Given an empty directory
 
-    When I run `wp scaffold package wp-cli/foo --skip-install`
+    When I run `wp package path`
+    Then save STDOUT as {PACKAGE_PATH}
+
+    When I run `wp scaffold package wp-cli/foo --skip-install --skip-github`
     Then STDOUT should contain:
       """
       Success: Created package files
@@ -243,3 +248,6 @@ Feature: Scaffold WP-CLI commands
       """
       Installing package
       """
+    And the {PACKAGE_PATH}/local/wp-cli/foo/.gitignore file should exist
+    And the {PACKAGE_PATH}/local/wp-cli/foo/.github/PULL_REQUEST_TEMPLATE file should not exist
+    And the {PACKAGE_PATH}/local/wp-cli/foo/.github/ISSUE_TEMPLATE file should not exist

src/ScaffoldPackageCommand.php

@@ -53,6 +53,9 @@ class ScaffoldPackageCommand {
 	 * [--skip-readme]
 	 * : Don't generate a README.md for the package.
 	 *
+	 * [--skip-github]
+	 * : Don't generate GitHub issue and pull request templates.
+	 *
 	 * [--skip-install]
 	 * : Don't install the package after scaffolding.
 	 *
@@ -124,6 +127,10 @@ public function package( $args, $assoc_args ) {
 			WP_CLI::runcommand( "scaffold package-readme {$package_dir} {$force_flag}", array( 'launch' => false ) );
 		}
 
+		if ( ! Utils\get_flag_value( $assoc_args, 'skip-github' ) ) {
+			WP_CLI::runcommand( "scaffold package-github {$package_dir} {$force_flag}", array( 'launch' => false ) );
+		}
+
 		if ( ! Utils\get_flag_value( $assoc_args, 'skip-install' ) ) {
 			WP_CLI::runcommand( "package install {$package_dir}", array( 'launch' => false ) );
 		}