Show error messages when member save fails

Author: worksofliam

Forms/cmdBindings.cs

@@ -81,7 +81,7 @@ private void treeView1_NodeMouseDoubleClick(object sender, TreeNodeMouseClickEve
         public void runCommands(string[] commands, string[] errDsp)
         {
             IBMi.RunCommands(commands);
-            if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+            if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
 
             if (errDsp != null)
             {

Forms/commandEntry.cs

@@ -38,10 +38,10 @@ private void textBox1_KeyUp(object sender, KeyEventArgs e)
         public void runCommands(string[] commands)
         {
             IBMi.RunCommands(commands);
-            loadNewCommands();
+            loadNewOutput();
         }
 
-        public void loadNewCommands()
+        public void loadNewOutput()
         {
             Invoke((MethodInvoker)delegate
             {

Forms/errorListing.cs

@@ -82,7 +82,7 @@ private void onSelectError(string File, int Line, int Col)
                 }
             }
 
-            if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+            if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
 
             MessageBox.Show("Unable to open error. Please open the source manually first and then try again.", "Information", MessageBoxButtons.OK, MessageBoxIcon.Information);
         }

Forms/openMember.cs

@@ -51,7 +51,7 @@ private void button1_Click(object sender, EventArgs e)
             }
 
             string resultFile = IBMiUtilities.DownloadMember(textBox1.Text, textBox2.Text, textBox3.Text);
-            if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+            if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
 
             if (resultFile != "")
             {

Forms/selectMember.cs

@@ -61,7 +61,7 @@ public void UpdateListing(string Lib, string Obj)
                 else
                 {
                     listView1.Items.Add(new ListViewItem("No members found!", 1));
-                    if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+                    if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
 
                     toolStripLabel2.Text = "0 members";
                 }
@@ -73,7 +73,7 @@ private void OpenMember(string Lib, string Obj, string Mbr, Boolean Editing)
         {
             Thread gothread = new Thread((ThreadStart)delegate {
                 string resultFile = IBMiUtilities.DownloadMember(Lib, Obj, Mbr);
-                if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+                if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
 
                 if (resultFile != "")
                 {

Forms/uploadMember.cs

@@ -59,7 +59,7 @@ private void button1_Click(object sender, EventArgs e)
                 }
                 else
                 {
-                    if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+                    if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
                     MessageBox.Show("Failed to save " + this._Member.GetMember() + ". Please check the Command Entry output.");
                 }
             }

IBMiTools/IBMiCommandInstaller.cs

@@ -38,7 +38,7 @@ internal static void InstallRemoteLib(string library = "QGPL")
                 }
                 IBMiUtilities.DebugLog("InstallRemoteLib - DONE!");
 
-                if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+                if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
             });
             thread.Start();
         }

LanguageTools/NppFunctions.cs

@@ -100,14 +100,14 @@ public static void HandleTrigger(SCNotification Notification)
                                 bool UploadResult = IBMiUtilities.UploadMember(member.GetLocalFile(), member.GetLibrary(), member.GetObject(), member.GetMember());
                                 if (UploadResult == false)
                                 {
-                                    IBMi.AddOutput("Failed to upload source to member!");
+                                    System.Windows.Forms.MessageBox.Show("Failed to upload to " + member.GetMember() + " on " + member.GetSystemName() + ".");
                                 }
                             }
                             else
                             {
-                                IBMi.AddOutput("Cannot save to member as not connected to correct system.");
+                                System.Windows.Forms.MessageBox.Show("Unable to upload to " + member.GetMember() + ". You must be connected to " + member.GetSystemName() + " in order to save this file.");
                             }
-                            if (Main.CommandWindow != null) Main.CommandWindow.loadNewCommands();
+                            if (Main.CommandWindow != null) Main.CommandWindow.loadNewOutput();
                         });
                         gothread.Start();
                     }