Skip to content

Commit fb7f954

Browse files
committed
Clarify comment on stub in ios_update_metadata_source_spec.rb
1 parent 6834bfd commit fb7f954

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

spec/ios_update_metadata_source_spec.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,13 @@
44
describe Fastlane::Actions::IosUpdateMetadataSourceAction do
55
before do
66
# This works around the `ensure_git_status_clean` call within the action.
7-
# It would be quite cumbersome to iterate on the code if we had to commit
8-
# every change _before_ running the tests...
7+
#
8+
# We can't easily remove the need to stub the call here without removing the check in the action.
9+
# In the tests, we move into a temp folder, but then create files in that directory.
10+
# So, `ensure_git_status_clean` will fail anyway, unless we add more cruft to the tests.
11+
#
12+
# See also conversation in
13+
# https://github.com/wordpress-mobile/release-toolkit/pull/352
914
allow(Fastlane::Actions::EnsureGitStatusCleanAction).to receive(:run)
1015
end
1116

0 commit comments

Comments
 (0)