Skip to content

Commit eaf6ac7

Browse files
committed
Fix Typos and Rubocop Issues
1 parent 9031f81 commit eaf6ac7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_download_file_by_version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def self.available_options
5858
description: 'The prefix which is used in the GitHub release title',
5959
type: String,
6060
optional: true),
61-
Fastlane::Helper::GithubHelper.github_token_config_item
61+
Fastlane::Helper::GithubHelper.github_token_config_item,
6262
]
6363
end
6464

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def self.update_milestone(repository:, number:, options:)
196196
# Remove the protection of a single branch from a repository
197197
#
198198
# @param [String] repository The repository name (including the organization)
199-
# @param [String] number The branch name
199+
# @param [String] branch The branch name
200200
# @param [Hash] options A customizable set of options.
201201
# @see https://docs.github.com/en/rest/branches/branch-protection#update-branch-protection
202202
#
@@ -207,7 +207,7 @@ def self.remove_branch_protection(repository:, branch:, options:)
207207
# Protects a single branch from a repository
208208
#
209209
# @param [String] repository The repository name (including the organization)
210-
# @param [String] number The branch name
210+
# @param [String] branch The branch name
211211
# @param options [Hash] A customizable set of options.
212212
# @see https://docs.github.com/en/rest/branches/branch-protection#update-branch-protection
213213
#

spec/github_helper_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,17 @@
3939

4040
it 'fails if it does not find the right release on GitHub' do
4141
stub = stub_request(:get, content_url).to_return(status: [404, 'Not Found'])
42-
donwloaded_file = described_class.download_file_from_tag(repository: test_repo, tag: test_tag, file_path: test_file, download_folder: './')
43-
expect(donwloaded_file).to be_nil
42+
downloaded_file = described_class.download_file_from_tag(repository: test_repo, tag: test_tag, file_path: test_file, download_folder: './')
43+
expect(downloaded_file).to be_nil
4444
expect(stub).to have_been_made.once
4545
end
4646

4747
it 'writes the raw content to a file' do
4848
stub = stub_request(:get, content_url).to_return(status: 200, body: 'my-test-content')
4949
Dir.mktmpdir('a8c-download-repo-file-') do |tmpdir|
5050
dst_file = File.join(tmpdir, 'test-file.xml')
51-
donwloaded_file = described_class.download_file_from_tag(repository: test_repo, tag: test_tag, file_path: test_file, download_folder: tmpdir)
52-
expect(donwloaded_file).to eq(dst_file)
51+
downloaded_file = described_class.download_file_from_tag(repository: test_repo, tag: test_tag, file_path: test_file, download_folder: tmpdir)
52+
expect(downloaded_file).to eq(dst_file)
5353
expect(stub).to have_been_made.once
5454
expect(File.read(dst_file)).to eq('my-test-content')
5555
end

0 commit comments

Comments
 (0)