Skip to content

Commit e9a0f3f

Browse files
committed
Send data for all devices in each variant
Instead of only the first. As per discussed in paaHJt-3od-p2#comment-6090
1 parent 25e367f commit e9a0f3f

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ def self.run(params)
1616
if File.exist?(app_thinning_plist_path)
1717
plist = Plist.parse_xml(app_thinning_plist_path)
1818
plist['variants'].each do |_key, variant|
19-
# FIXME: We should probably not take only the first `variantDescriptor` from the list. But that'll do for now as a draft implementation.
20-
vd = variant['variantDescriptors']&.first
21-
variant_metadata = vd.nil? ? { device: 'Universal' } : { device: vd['device'], 'OS Version': vd['os-version'] }
22-
payload.add_metric(name: 'Download Size', value: variant['sizeCompressedApp'], meta: variant_metadata)
23-
payload.add_metric(name: 'Install Size', value: variant['sizeUncompressedApp'], meta: variant_metadata)
19+
variant_descriptors = variant['variantDescriptors'] || [{ 'device' => 'Universal' }]
20+
variant_descriptors.each do |desc|
21+
variant_metadata = { device: desc['device'], 'OS Version': desc['os-version'] }
22+
payload.add_metric(name: 'Download Size', value: variant['sizeCompressedApp'], meta: variant_metadata)
23+
payload.add_metric(name: 'Install Size', value: variant['sizeUncompressedApp'], meta: variant_metadata)
24+
end
2425
end
2526
end
2627

0 commit comments

Comments
 (0)