Skip to content

Commit be16aee

Browse files
Merge branch 'update/octokit' into update/buildkite-test-collector
2 parents 00655b1 + d2a1e86 commit be16aee

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.rubocop.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ Style/AsciiComments:
4848
# which would be incorrect and not what we want
4949
Style/StringConcatenation:
5050
Enabled: false
51+
52+
########## Gemspec Rules
53+
54+
# This was turned on by default after updating Rubocop to `1.50.2`. We want to disable this for now because
55+
# all the gem publishing is done within CI and doesn't allow for user input such as an MFA code. See
56+
# https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569313 for more discussion
57+
Gemspec/RequireMFA:
58+
Enabled: false
5159

5260
########## Metrics / Max Lengths Rules
5361

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
### Breaking Changes
88

9-
_None_
9+
- Update `octokit` to `5.6.1` This is a major version bump from version `4.18`. The [breaking change in version `5.0.0`](https://github.com/octokit/octokit.rb/releases/tag/v5.0.0) is dropping Ruby 2.6 and lower. [#464]
1010

1111
### New Features
1212

@@ -21,7 +21,7 @@ _None_
2121
- Add "Mobile Secrets" to `configure_update` current branch message to clarify which repo it's referring to. [#455]
2222
- `buildkite_trigger_build` now prints the web URL of the newly scheduled build, to allow you to easily open it via cmd-click. [#460]
2323
- Add the branch information to the 'This is not a release branch' error that's thrown from complete code freeze lane. [#461]
24-
- Update `octokit` to `5.6.1` and `danger` to `9.3.0`. These are both major version changes, but as the dependency is internal-only, it shouldn't be a breaking change for clients. [#464]
24+
- Update `danger` to `9.3.0`. This is an internal-only change and is not a breaking change for clients. [#464]
2525
- Replace `rspec-buildkite-analytics` with `buildkite-test_collector` (Buildkite renamed the gem) and update it to `2.2.0`. This is another internal-only change and is not a breaking change for clients. [#465]
2626

2727
## 7.0.0

0 commit comments

Comments
 (0)