Skip to content

Commit b56a3a0

Browse files
committed
Provide more (optional) metadata to spec payloads
1 parent 2b5cc64 commit b56a3a0

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

spec/android_send_app_size_metrics_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ def test_app_size_action(fake_aab_size:, fake_apks:, expected_payload:, **other_
7575
expected_payload: expected,
7676
app_name: 'my-app',
7777
app_version_name: '10.2-rc-3',
78-
build_type: 'Release',
7978
product_flavor: 'Vanilla',
79+
build_type: 'Release',
8080
source: 'unit-test',
8181
include_split_sizes: false
8282
)
@@ -100,7 +100,9 @@ def test_app_size_action(fake_aab_size:, fake_apks:, expected_payload:, **other_
100100
app_name: 'wordpress',
101101
app_version_name: '19.8-rc-3',
102102
app_version_code: 1214,
103-
build_type: 'fake-beta'
103+
product_flavor: 'Vanilla',
104+
build_type: 'Release',
105+
source: 'unit-test'
104106
)
105107
end
106108
end

spec/ios_send_app_size_metrics_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ def test_app_size_action(fake_ipa_size:, expected_payload:, **other_action_args)
9595
app_thinning_plist_path: app_thinning_plist_path,
9696
app_name: 'wordpress',
9797
build_type: 'internal',
98-
app_version: '19.8.0.2'
98+
app_version: '19.8.0.2',
99+
source: 'unit-test'
99100
)
100101
end
101102
end

spec/test-data/app_size_metrics/android-metrics-payload.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
{ "name": "App Name", "value": "wordpress" },
55
{ "name": "App Version", "value": "19.8-rc-3" },
66
{ "name": "Version Code", "value": 1214 },
7-
{ "name": "Build Type", "value": "fake-beta" }
7+
{ "name": "Product Flavor", "value": "Vanilla" },
8+
{ "name": "Build Type", "value": "Release" },
9+
{ "name": "Source", "value": "unit-test" }
810
],
911
"metrics": [
1012
{ "name": "AAB File Size", "value": 987654321 },

spec/test-data/app_size_metrics/ios-metrics-payload.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
{ "name": "Platform", "value": "iOS" },
44
{ "name": "App Name", "value": "wordpress" },
55
{ "name": "App Version", "value": "19.8.0.2" },
6-
{ "name": "Build Type", "value": "internal" }
6+
{ "name": "Build Type", "value": "internal" },
7+
{ "name": "Source", "value": "unit-test" }
78
],
89
"metrics": [
910
{ "name": "File Size", "value": 1337 },

0 commit comments

Comments
 (0)