Fix Style/SelfAssignment violations

Author: spencertransier

.rubocop_todo.yml

@@ -284,15 +284,6 @@ Style/SafeNavigation:
   Exclude:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb'
 
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Style/SelfAssignment:
-  Exclude:
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/an_metadata_update_helper.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_update_helper.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.

lib/fastlane/plugin/wpmreleasetoolkit/helper/an_metadata_update_helper.rb

@@ -83,7 +83,7 @@ def generate_keys(release_version)
         version_minor = Integer(values[1])
         @new_key = "#{@rel_note_key}_#{version_major.to_s.rjust(2, '0')}#{version_minor}"
 
-        version_major = version_major - 1 if version_minor == 0
+        version_major -= 1 if version_minor == 0
         version_minor = version_minor == 0 ? 9 : version_minor - 1
 
         @keep_key = "#{@rel_note_key}_#{version_major.to_s.rjust(2, '0')}#{version_minor}"

lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb

@@ -133,14 +133,14 @@ def self.merge_lib(main, library)
             case res
             when :updated
               UI.verbose "#{string_node.attr('name')} updated."
-              updated_count = updated_count + 1
+              updated_count += 1
             when :found
-              untouched_count = untouched_count + 1
+              untouched_count += 1
             when :added
               UI.verbose "#{string_node.attr('name')} added."
-              added_count = added_count + 1
+              added_count += 1
             when :skipped
-              skipped_count = skipped_count + 1
+              skipped_count += 1
             else
               UI.user_error!("Internal Error! #{res}")
             end

lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb

@@ -489,13 +489,13 @@ def self.update_version(version, section)
                   if line.include?('versionName') && !line.include?('"versionName"') && !line.include?('PversionName')
                     version_name = line.split[1].tr('\"', '')
                     line.sub!(version_name, version[VERSION_NAME].to_s)
-                    version_updated = version_updated + 1
+                    version_updated += 1
                   end
 
                   if line.include? 'versionCode'
                     version_code = line.split[1]
                     line.sub!(version_code, version[VERSION_CODE].to_s)
-                    version_updated = version_updated + 1
+                    version_updated += 1
                   end
                 end
                 temp_file.puts line

lib/fastlane/plugin/wpmreleasetoolkit/helper/metadata_update_helper.rb

@@ -87,7 +87,7 @@ def generate_keys(release_version)
         version_minor = Integer(values[1])
         @new_key = "#{@rel_note_key}_#{version_major}#{version_minor}"
 
-        version_major = version_major - 1 if version_minor == 0
+        version_major -= 1 if version_minor == 0
         version_minor = version_minor == 0 ? 9 : version_minor - 1
 
         @keep_key = "#{@rel_note_key}_#{version_major}#{version_minor}"
@@ -147,7 +147,7 @@ def generate_keys(release_version)
         version_minor = Integer(values[1])
         @new_key = "v#{release_version}-whats-new"
 
-        version_major = version_major - 1 if version_minor == 0
+        version_major -= 1 if version_minor == 0
         version_minor = version_minor == 0 ? 9 : version_minor - 1
 
         @old_key = "v#{version_major}.#{version_minor}-whats-new"