Skip to content

Commit 92da6e4

Browse files
committed
Revert changes about imagemagick from pipeline.yml
Turns out `brew install imagemagick` is still necessary after all on CI, if not for running the tests themselves, at least for installing the gems from the Gemfile. This is because: - Our `Gemfile` includes the `gemspec` directive, which includes all the gem dependencies declared in our `.gemspec` as part of the `Gemfile`. This is typical in a gem repo like here, as the goal is to ensure that working on and testing the codebase would always use the same dependencies as the gem itself uses. - Our `.gemspec` contains `rmagick` as one of its dependency - Which in turn needs the `imagemagick` formula/library to be installed (via `brew`), otherwise we will get an error during `bundle install`. So in short, running `bundle install` will try to install all the gems from the `Gemfile`, which is a superset of the dependecies from the `.gemspec` and thus will try to install the `rmagick` gem, which requires `imagemagick` to be installed.
1 parent 6722fe6 commit 92da6e4

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.buildkite/pipeline.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,10 @@ steps:
2424
- label: "🧪 Build and Test"
2525
key: test
2626
command: |
27+
# We only need this for tasks running on a Mac
28+
brew install pkg-config git-lfs libxml2 imagemagick@6
29+
2730
echo "--- :git: Setting up git-lfs"
28-
brew install git-lfs
2931
git-lfs install
3032
3133
echo "--- :rubygems: Setting up Gems"

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ _None_
1818

1919
### Internal Changes
2020

21-
* Speed up our CI by removing now-useless installation of ImageMagick on CI to run the "Build and Test" step. [#348]
21+
_None_
2222

2323
## 4.0.0
2424

0 commit comments

Comments
 (0)