Fix Lint/UselessAccessModifier violations

Author: spencertransier

.rubocop_todo.yml

@@ -25,21 +25,6 @@ Lint/NonLocalExitFromIterator:
     - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb'
     - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb'
 
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_beta.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_final_release.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_release.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_beta.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb'
-    - 'lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb'
-
 # Offense count: 6
 Lint/UselessAssignment:
   Exclude:

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_beta.rb

@@ -47,8 +47,6 @@ def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end
 
-      private
-
       def self.create_config
         @current_version = Fastlane::Helper::Ios::VersionHelper.get_build_version
         @current_version_internal = Fastlane::Helper::Ios::VersionHelper.get_internal_version unless ENV['INTERNAL_CONFIG_FILE'].nil?

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_hotfix.rb

@@ -78,8 +78,6 @@ def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end
 
-      private
-
       def self.create_config(previous_version, new_short_version)
         @current_version = previous_version
         @current_version_internal = Fastlane::Helper::Ios::VersionHelper.get_internal_version unless ENV['INTERNAL_CONFIG_FILE'].nil?

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb

@@ -78,8 +78,6 @@ def self.is_supported?(platform)
         [:ios, :mac].include?(platform)
       end
 
-      private
-
       def self.create_config
         @current_version = Fastlane::Helper::Ios::VersionHelper.get_build_version
         @current_version_internal = Fastlane::Helper::Ios::VersionHelper.get_internal_version unless ENV['INTERNAL_CONFIG_FILE'].nil?

lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_version_helper.rb

@@ -349,7 +349,6 @@ def self.get_library_version_from_gradle_config(import_key:)
         end
 
         #----------------------------------------
-        private
 
         # Remove the beta suffix (part after the `-`) from a version string
         #

lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb

@@ -248,7 +248,6 @@ def self.update_xc_config(file_path, new_version, new_version_short)
         end
 
         #----------------------------------------
-        private
 
         # Split a version string into its 4 parts, ensuring its parts count is valid
         #