Skip to content

Commit 81ae374

Browse files
committed
Don't remove the base- prefix from the split name
1 parent 49e0c21 commit 81ae374

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_send_app_size_metrics.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def self.run(params)
3535

3636
apks.each do |apk|
3737
UI.message("[App Size Metrics] Computing file and download size of #{File.basename(apk)}...")
38-
split_name = File.basename(apk, '.apk').delete_prefix('base-')
38+
split_name = File.basename(apk, '.apk')
3939
file_size = Action.sh(apkanalyzer_bin, 'apk', 'file-size', apk, print_command: false, print_command_output: false).chomp.to_i
4040
download_size = Action.sh(apkanalyzer_bin, 'apk', 'download-size', apk, print_command: false, print_command_output: false).chomp.to_i
4141
metrics_helper.add_metric(name: 'APK File Size', value: file_size, meta: { split: split_name })

spec/test-data/app_size_metrics/android-metrics-payload.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
],
1111
"metrics": [
1212
{ "name": "AAB File Size", "value": 987654321 },
13-
{ "name": "APK File Size", "value": 164082, "meta": [{ "name": "split", "value": "arm64_v8a_2" }] },
14-
{ "name": "Download Size", "value": 64082, "meta": [{ "name": "split", "value": "arm64_v8a_2" }] },
15-
{ "name": "APK File Size", "value": 150072, "meta": [{ "name": "split", "value": "armeabi_v7a_2" }] },
16-
{ "name": "Download Size", "value": 50072, "meta": [{ "name": "split", "value": "armeabi_v7a_2" }] },
17-
{ "name": "APK File Size", "value": 150002, "meta": [{ "name": "split", "value": "armeabi_2" }] },
18-
{ "name": "Download Size", "value": 50002, "meta": [{ "name": "split", "value": "armeabi_2" }] },
19-
{ "name": "APK File Size", "value": 164080, "meta": [{ "name": "split", "value": "arm64_v8a" }] },
20-
{ "name": "Download Size", "value": 64080, "meta": [{ "name": "split", "value": "arm64_v8a" }] },
21-
{ "name": "APK File Size", "value": 150000, "meta": [{ "name": "split", "value": "armeabi" }] },
22-
{ "name": "Download Size", "value": 50000, "meta": [{ "name": "split", "value": "armeabi" }] },
23-
{ "name": "APK File Size", "value": 150070, "meta": [{ "name": "split", "value": "armeabi_v7a" }] },
24-
{ "name": "Download Size", "value": 50070, "meta": [{ "name": "split", "value": "armeabi_v7a" }] }
13+
{ "name": "APK File Size", "value": 164082, "meta": [{ "name": "split", "value": "base-arm64_v8a_2" }] },
14+
{ "name": "Download Size", "value": 64082, "meta": [{ "name": "split", "value": "base-arm64_v8a_2" }] },
15+
{ "name": "APK File Size", "value": 150072, "meta": [{ "name": "split", "value": "base-armeabi_v7a_2" }] },
16+
{ "name": "Download Size", "value": 50072, "meta": [{ "name": "split", "value": "base-armeabi_v7a_2" }] },
17+
{ "name": "APK File Size", "value": 150002, "meta": [{ "name": "split", "value": "base-armeabi_2" }] },
18+
{ "name": "Download Size", "value": 50002, "meta": [{ "name": "split", "value": "base-armeabi_2" }] },
19+
{ "name": "APK File Size", "value": 164080, "meta": [{ "name": "split", "value": "base-arm64_v8a" }] },
20+
{ "name": "Download Size", "value": 64080, "meta": [{ "name": "split", "value": "base-arm64_v8a" }] },
21+
{ "name": "APK File Size", "value": 150000, "meta": [{ "name": "split", "value": "base-armeabi" }] },
22+
{ "name": "Download Size", "value": 50000, "meta": [{ "name": "split", "value": "base-armeabi" }] },
23+
{ "name": "APK File Size", "value": 150070, "meta": [{ "name": "split", "value": "base-armeabi_v7a" }] },
24+
{ "name": "Download Size", "value": 50070, "meta": [{ "name": "split", "value": "base-armeabi_v7a" }] }
2525
]
2626
}

0 commit comments

Comments
 (0)