Merge branch 'trunk' into add/get-build-number-action

Author: spencertransier

CHANGELOG.md

@@ -21,6 +21,9 @@ _None_
 ### Internal Changes
 
 - Add "Mobile Secrets" to `configure_update` current branch message to clarify which repo it's referring to. [#455]
+- `buildkite_trigger_build` now prints the web URL of the newly scheduled build, to allow you to easily open it via cmd-click. [#460]
+- Add the branch information to the 'This is not a release branch' error that's thrown from complete code freeze lane. [#461]
+- Adds `ignore_pipeline_branch_filters=true` parameter to the API call triggering a Buildkite build [#468]
 
 ## 7.0.0
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_completecodefreeze_prechecks.rb

@@ -7,7 +7,7 @@ def self.run(params)
         require_relative '../../helper/android/android_version_helper'
         require_relative '../../helper/android/android_git_helper'
 
-        UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
+        UI.user_error!("Current branch - '#{other_action.git_branch}' - is not a release branch. Abort.") unless other_action.git_branch.start_with?('release/')
 
         version = Fastlane::Helper::Android::VersionHelper.get_public_version
         message = "Completing code freeze for: #{version}\n"

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_trigger_build_action.rb

@@ -13,7 +13,11 @@ def self.run(params)
           branch: params[:branch],
           commit: params[:commit],
           env: params[:environment].merge(pipeline_name),
-          message: params[:message]
+          message: params[:message],
+          # Buildkite will not trigger a build if the GitHub activity for that branch is turned off
+          # We want API triggers to work regardless of the GitHub activity settings, so this option is necessary
+          # https://forum.buildkite.community/t/request-build-error-branches-have-been-disabled-for-this-pipeline/1463/2
+          ignore_pipeline_branch_filters: true
         }.compact # remove entries with `nil` values from the Hash, if any
 
         client = Buildkit.new(token: params[:buildkite_token])
@@ -23,7 +27,11 @@ def self.run(params)
           options
         )
 
-        response.state == 'scheduled' ? UI.message('Done!') : UI.crash!("Failed to start job\nError: [#{response}]")
+        if response.state == 'scheduled'
+          UI.message("Successfully scheduled new build. You can see it at '#{response.web_url}'")
+        else
+          UI.crash!("Failed to start job\nError: [#{response}]")
+        end
       end
 
       #####################################################

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_action.rb

@@ -16,7 +16,7 @@ def self.run(params)
         prerelease = params[:prerelease]
         is_draft = params[:is_draft]
 
-        UI.message("Creating draft release #{version} in #{repository}.")
+        UI.message("Creating #{is_draft ? 'draft ' : ''}release #{version} in #{repository}.")
         # Verify assets
         assets.each do |file_path|
           UI.user_error!("Can't find file #{file_path}!") unless File.exist?(file_path)

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_completecodefreeze_prechecks.rb

@@ -7,7 +7,7 @@ def self.run(params)
         require_relative '../../helper/ios/ios_version_helper'
         require_relative '../../helper/ios/ios_git_helper'
 
-        UI.user_error!('This is not a release branch. Abort.') unless other_action.git_branch.start_with?('release/')
+        UI.user_error!("Current branch - '#{other_action.git_branch}' - is not a release branch. Abort.") unless other_action.git_branch.start_with?('release/')
 
         version = Fastlane::Helper::Ios::VersionHelper.get_public_version
         message = "Completing code freeze for: #{version}\n"