Use get_from_env util method instead of accessing environment var directly

iangmaia · iangmaia · commit 69f5e039736e · 2023-01-29T19:32:07.000+01:00
diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb b/lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb
@@ -15,7 +15,7 @@ module GitHelper
         # @param [Bool] include_deliverfile If true (the default), includes the `fastlane/Deliverfile` in files being commited
         #
         def self.commit_version_bump(include_deliverfile: true)
-          files_list = [File.join(ENV['PROJECT_ROOT_FOLDER'], 'config', '.')]
+          files_list = [File.join(get_from_env!(key: 'PROJECT_ROOT_FOLDER'), 'config', '.')]
           files_list.append File.join('fastlane', 'Deliverfile') if include_deliverfile
 
           Fastlane::Helper::GitHelper.commit(message: 'Bump version number', files: files_list, push: true)

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ module GitHelper`
`15`	`15`	# @param [Bool] include_deliverfile If true (the default), includes the `fastlane/Deliverfile` in files being commited
`16`	`16`	`#`
`17`	`17`	`def self.commit_version_bump(include_deliverfile: true)`
`18`		`- files_list = [File.join(ENV['PROJECT_ROOT_FOLDER'], 'config', '.')]`
	`18`	`+ files_list = [File.join(get_from_env!(key: 'PROJECT_ROOT_FOLDER'), 'config', '.')]`
`19`	`19`	`files_list.append File.join('fastlane', 'Deliverfile') if include_deliverfile`
`20`	`20`
`21`	`21`	`Fastlane::Helper::GitHelper.commit(message: 'Bump version number', files: files_list, push: true)`