GithubHelperSpec: Add Yard Docs and Named Parameters to create_milestone method

To become this method cleaner and more legible to call, we're adding named parameters to it, following the name of the current ones, and also adding yard docs to help guide the new people who use it

Author: raafaelima

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -71,7 +71,18 @@ def get_last_milestone(repository)
         last_stone
       end
 
-      def create_milestone(repository, newmilestone_number, newmilestone_duedate, newmilestone_duration, number_of_days_from_code_freeze_to_release, need_submission)
+      # Creates a new milestone
+      #
+      # @param [String] repository The repository name, including the organization (e.g. `wordpress-mobile/wordpress-ios`)
+      # @param [String] newmilestone_number The name of the milestone we want to create (e.g.: `16.9`)
+      # @param [Time] newmilestone_duedate milestone due date (e.g. `2022-10-22T12:00:00Z`)
+      # @param [Integer] newmilestone_duration Milestone duration in number of days
+      # @param [Integer] number_of_days_from_code_freeze_to_release Number of days from code freeze to release
+      # @param [Boolean] need_submission The app needs to be submitted?
+      #  if `true`, will subtract 3 days from the `:number_of_days_from_code_freeze_to_release`.
+      #  if `false`, will use the days of `:newmilestone_duration`
+      #
+      def create_milestone(repository:, newmilestone_number:, newmilestone_duedate:, newmilestone_duration:, number_of_days_from_code_freeze_to_release:, need_submission:)
         # If there is a review process, we want to submit the binary 3 days before its release
         #
         # Using 3 days is mostly for historical reasons where we release the apps on Monday and submit them on Friday.

spec/github_helper_spec.rb

@@ -236,12 +236,12 @@ def get_milestone(milestone_name:)
     def create_milestone(need_submission:, milestone_duration:, days_code_freeze:)
       helper = described_class.new(github_token: 'Fake-GitHubToken-123')
       helper.create_milestone(
-        test_repo,
-        test_milestone_number,
-        test_milestone_duedate.to_time.utc,
-        milestone_duration,
-        days_code_freeze,
-        need_submission
+        repository: test_repo,
+        newmilestone_number: test_milestone_number,
+        newmilestone_duedate: test_milestone_duedate.to_time.utc,
+        newmilestone_duration: milestone_duration,
+        number_of_days_from_code_freeze_to_release: days_code_freeze,
+        need_submission: need_submission
       )
     end
   end