Skip to content

Commit 53e4bf8

Browse files
committed
Update specs accordingly
No mode empty lines in the final XML due to unwanted moves (aka remove-and-readd)!
1 parent 88b5b89 commit 53e4bf8

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

spec/an_localize_libs_action_spec.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ def write_android_xml(path, lines)
7575

7676
expected = [
7777
'<string name="override-true" content_override="true">from app override-true</string>',
78-
'', '', # FIXME: Current implementation adds empty lines; we should get rid of those at some point
7978
'<string name="override-false">from lib override-false</string>',
8079
'<string name="override-missing">from lib override-missing</string>',
8180
]
@@ -118,11 +117,9 @@ def write_android_xml(path, lines)
118117

119118
expected = [
120119
'<string name="override-true" content_override="true">from app override-true</string>',
121-
'', # FIXME: Current implementation adds empty lines; we should get rid of those at some point
122-
'<string name="lib1-key" a8c-src-lib="lib1-id">Key only present in lib1</string>',
123120
'<string name="override-missing" a8c-src-lib="lib2-id">from lib2 override-missing</string>',
121+
'<string name="lib1-key" a8c-src-lib="lib1-id">Key only present in lib1</string>',
124122
'<string name="lib2-key" a8c-src-lib="lib2-id">Key only present in lib2</string>',
125-
'', # FIXME: Current implementation adds empty lines; we should get rid of those at some point
126123
]
127124
expect(File.read(app_strings_path)).to eq(android_xml_with_lines(expected))
128125
end
@@ -212,9 +209,8 @@ def write_android_xml(path, lines)
212209

213210
expected = [
214211
'<string name="override-true" content_override="true">from app override-true</string>',
215-
'', # FIXME: Current implementation adds empty lines; we should get rid of those at some point
216-
'<string name="override-missing">from app override-missing</string>',
217212
'<string name="override-false">from lib override-false</string>',
213+
'<string name="override-missing">from app override-missing</string>',
218214
]
219215
expect(File.read(app_strings_path)).to eq(android_xml_with_lines(expected))
220216
end

0 commit comments

Comments
 (0)