Make rubocop happy

Author: AliSoftware

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_send_app_size_metrics.rb

@@ -13,13 +13,13 @@ def self.run(params)
 
         # Build the payload base
         payload = Fastlane::WPMRT::AppSizeMetricsPayload.new(
-          'Platform': 'Android',
+          Platform: 'Android',
           'App Name': params[:app_name],
           'App Version': params[:app_version_name],
           'Version Code': params[:app_version_code],
           'Product Flavor': params[:product_flavor],
           'Build Type': params[:build_type],
-          'Source': params[:source],
+          Source: params[:source]
         )
         payload.add_metric(name: 'AAB File Size', value: File.size(params[:aab_path]))
 
@@ -54,12 +54,10 @@ def self.run(params)
       end
 
       def self.check_bundletool_installed!
-        begin
-          Action.sh('command', '-v', 'bundletool', print_command: false, print_command_output: false)
-        rescue
-          UI.user_error!('bundletool is required to build the split APKs. Install it with `brew install bundletool`')
-          raise
-        end
+        Action.sh('command', '-v', 'bundletool', print_command: false, print_command_output: false)
+      rescue StandardError
+        UI.user_error!('bundletool is required to build the split APKs. Install it with `brew install bundletool`')
+        raise
       end
 
       def self.find_apkanalyzer_binary!
@@ -159,7 +157,6 @@ def self.available_options
             description: 'The path to the .ipa to extract size information from',
             type: String,
             optional: false,
-            #default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
             verify_block: proc do |value|
               UI.user_error!('You must provide an path to an existing `.aab` file') unless File.exist?(value)
             end

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb

@@ -14,11 +14,11 @@ def self.run(params)
 
         # Build the payload base
         payload = Fastlane::WPMRT::AppSizeMetricsPayload.new(
-          'Platform': 'iOS',
+          Platform: 'iOS',
           'App Name': params[:app_name],
           'App Version': params[:app_version],
           'Build Type': params[:build_type],
-          'Source': params[:source],
+          Source: params[:source]
         )
         payload.add_metric(name: 'File Size', value: File.size(params[:ipa_path]))
 

spec/android_send_app_size_metrics_spec.rb

@@ -42,7 +42,7 @@ def test_app_size_action(fake_aab_size:, fake_apks:, expected_payload:, **other_
       expect(code).to eq(201)
       expect(File).to exist(output_file)
       generated_payload = File.read(output_file)
-      unless other_action_args[:use_gzip_content_encoding] === false
+      unless other_action_args[:use_gzip_content_encoding] == false
         expect do
           generated_payload = Zlib.gunzip(generated_payload)
         end.not_to raise_error, 'Payload was not valid GZipped data'
@@ -94,7 +94,7 @@ def test_app_size_action(fake_aab_size:, fake_apks:, expected_payload:, **other_
         'base-armeabi.apk': [150_000, 50_000],
         'base-armeabi_2.apk': [150_002, 50_002],
         'base-armeabi_v7a.apk': [150_070, 50_070],
-        'base-armeabi_v7a_2.apk': [150_072, 50_072],
+        'base-armeabi_v7a_2.apk': [150_072, 50_072]
       },
       expected_payload: expected,
       app_name: 'wordpress',

spec/ios_send_app_size_metrics_spec.rb

@@ -3,7 +3,7 @@
 describe Fastlane::Actions::IosSendAppSizeMetricsAction do
   let(:test_data_dir) { File.join(File.dirname(__FILE__), 'test-data', 'app_size_metrics') }
   let(:fake_ipa_size) { 1337 } # The value used in the `app-thinning.plist` and `ios-metrics-payload.json` fixtures
-  
+
   def test_app_size_action(fake_ipa_size:, expected_payload:, **other_action_args)
     in_tmp_dir do |tmp_dir|
       # Arrange
@@ -23,7 +23,7 @@ def test_app_size_action(fake_ipa_size:, expected_payload:, **other_action_args)
       expect(code).to eq(201)
       expect(File).to exist(output_file)
       generated_payload = File.read(output_file)
-      unless other_action_args[:use_gzip_content_encoding] === false
+      unless other_action_args[:use_gzip_content_encoding] == false
         expect do
           generated_payload = Zlib.gunzip(generated_payload)
         end.not_to raise_error, 'Payload was not valid GZipped data'