Skip to content

Commit 4eb66bd

Browse files
committed
Remove skip_glotpress parameter from the ios_bump_version_release Action
1 parent 58c839c commit 4eb66bd

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_bump_version_release.rb

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@ def self.run(params)
2121
Fastlane::Helper::GitHelper.create_branch(@new_release_branch, from: default_branch)
2222
UI.message 'Done!'
2323

24-
UI.message 'Updating glotPressKeys...' unless params[:skip_glotpress]
25-
update_glotpress_key unless params[:skip_glotpress]
26-
UI.message 'Done' unless params[:skip_glotpress]
27-
2824
UI.message 'Updating Fastlane deliver file...' unless params[:skip_deliver]
2925
Fastlane::Helper::Ios::VersionHelper.update_fastlane_deliver(@new_short_version) unless params[:skip_deliver]
3026
UI.message 'Done!' unless params[:skip_deliver]
@@ -35,7 +31,7 @@ def self.run(params)
3531

3632
Fastlane::Helper::Ios::GitHelper.commit_version_bump(
3733
include_deliverfile: !params[:skip_deliver],
38-
include_metadata: !params[:skip_glotpress]
34+
include_metadata: false
3935
)
4036

4137
UI.message 'Done.'
@@ -55,16 +51,11 @@ def self.details
5551

5652
def self.available_options
5753
[
58-
FastlaneCore::ConfigItem.new(key: :skip_glotpress,
59-
env_name: 'FL_IOS_CODEFREEZE_BUMP_SKIPGLOTPRESS',
60-
description: 'Skips GlotPress key update',
61-
is_string: false, # true: verifies the input is a string, false: every kind of value
62-
default_value: false), # the default value if the user didn't provide one
6354
FastlaneCore::ConfigItem.new(key: :skip_deliver,
6455
env_name: 'FL_IOS_CODEFREEZE_BUMP_SKIPDELIVER',
6556
description: 'Skips Deliver key update',
66-
is_string: false, # true: verifies the input is a string, false: every kind of value
67-
default_value: false), # the default value if the user didn't provide one
57+
type: Boolean,
58+
default_value: false),
6859
FastlaneCore::ConfigItem.new(key: :default_branch,
6960
env_name: 'FL_RELEASE_TOOLKIT_DEFAULT_BRANCH',
7061
description: 'Default branch of the repository',
@@ -105,15 +96,6 @@ def self.show_config
10596
UI.message("New short version: #{@new_short_version}")
10697
UI.message("Release branch: #{@new_release_branch}")
10798
end
108-
109-
def self.update_glotpress_key
110-
dm_file = ENV['DOWNLOAD_METADATA']
111-
if File.exist?(dm_file)
112-
sh("sed -i '' \"s/let glotPressWhatsNewKey.*/let glotPressWhatsNewKey = \\\"v#{@new_short_version}-whats-new\\\"/\" #{dm_file}")
113-
else
114-
UI.user_error!("Can't find #{dm_file}.")
115-
end
116-
end
11799
end
118100
end
119101
end

0 commit comments

Comments
 (0)