Fix pipeline upload error detection

Author: AliSoftware

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/buildkite_add_trigger_step_action.rb

@@ -38,10 +38,10 @@ def self.run(params)
         }.to_yaml
 
         # Use buildkite-agent to upload the pipeline
-        _stdout, stderr, _status = Open3.capture3('buildkite-agent', 'pipeline', 'upload', stdin_data: trigger_yaml)
+        _stdout, stderr, status = Open3.capture3('buildkite-agent', 'pipeline', 'upload', stdin_data: trigger_yaml)
 
         # Check for errors
-        UI.user_error!("Failed to upload pipeline: #{stderr}") unless stderr.empty?
+        UI.user_error!("Failed to upload pipeline: #{stderr}") unless status.success?
 
         # Log success
         UI.success("Added a trigger step to the current Buildkite build to start a new build for #{pipeline_file} on branch #{branch}")

spec/buildkite_add_trigger_step_action_spec.rb

@@ -130,8 +130,8 @@ def expected_yaml(
     end
   end
 
-  context 'when the pipeline upload fails' do
-    it 'raises a user error with the error message' do
+  context 'when pipeline upload errors' do
+    it 'raises a user error when the command fails' do
       error_message = 'Failed to upload pipeline'
       allow(Open3).to receive(:capture3)
         .with('buildkite-agent', 'pipeline', 'upload', stdin_data: expected_yaml)
@@ -148,6 +148,24 @@ def expected_yaml(
         async: async
       )
     end
+
+    it 'does not error when the command succeeds, even with stderr output' do
+      stderr_message = 'Some warning message'
+      allow(Open3).to receive(:capture3)
+        .with('buildkite-agent', 'pipeline', 'upload', stdin_data: expected_yaml)
+        .and_return(['', stderr_message, instance_double(Process::Status, success?: true)])
+
+      expect(FastlaneCore::UI).not_to receive(:user_error!)
+
+      run_described_fastlane_action(
+        pipeline_file: pipeline_file,
+        branch: branch,
+        message: message,
+        environment: environment,
+        buildkite_pipeline_slug: buildkite_pipeline_slug,
+        async: async
+      )
+    end
   end
 
   context 'when required parameters are missing' do