Skip to content

Commit 41b6e8e

Browse files
AliSoftwaremokagio
andauthored
Apply suggestions from code review
Co-authored-by: Gio Lodi <giovanni.lodi42@gmail.com>
1 parent f804caf commit 41b6e8e

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_send_app_size_metrics.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,35 +97,35 @@ def self.available_options
9797
FastlaneCore::ConfigItem.new(
9898
key: :app_name,
9999
env_name: 'FL_IOS_SEND_APP_SIZE_METRICS_APP_NAME',
100-
description: 'The name of the app for which we are publishing metrics, to help filter by app in the dashboard',
100+
description: 'The name of the app for which we are publishing metrics, to help with filtering and grouping',
101101
type: String,
102102
optional: false
103103
),
104104
FastlaneCore::ConfigItem.new(
105105
key: :app_version,
106106
env_name: 'FL_IOS_SEND_APP_SIZE_METRICS_APP_VERSION',
107-
description: 'The version of the app for which we are publishing metrics, to help filter by version in the dashboard',
107+
description: 'The version of the app for which we are publishing metrics, to help with filtering and grouping',
108108
type: String,
109109
optional: false
110110
),
111111
FastlaneCore::ConfigItem.new(
112112
key: :build_type,
113113
env_name: 'FL_IOS_SEND_APP_SIZE_METRICS_BUILD_TYPE',
114-
description: 'The build configuration for which we are publishing metrics, to help filter by build config in the dashboard. E.g. `Debug`, `Release`',
114+
description: 'The build configuration for which we are publishing metrics, to help with filtering and grouping. E.g. `Debug`, `Release`',
115115
type: String,
116116
optional: true
117117
),
118118
FastlaneCore::ConfigItem.new(
119119
key: :source,
120120
env_name: 'FL_IOS_SEND_APP_SIZE_METRICS_SOURCE',
121-
description: 'The type of event at the origin of that build, to help filter data in the dashboard. E.g. `pr`, `beta`, `final-release`',
121+
description: 'The type of event at the origin of that build, to help with filtering and grouping. E.g. `pr`, `beta`, `final-release`',
122122
type: String,
123123
optional: true
124124
),
125125
FastlaneCore::ConfigItem.new(
126126
key: :ipa_path,
127127
env_name: 'FL_IOS_SEND_APP_SIZE_METRICS_IPA_PATH',
128-
description: 'The path to the .ipa to extract size information from',
128+
description: 'The path to the `.ipa` to extract size information from',
129129
type: String,
130130
optional: false,
131131
default_value: Actions.lane_context[SharedValues::IPA_OUTPUT_PATH],
@@ -158,7 +158,7 @@ def self.authors
158158
end
159159

160160
def self.is_supported?(platform)
161-
[:ios, :mac].include? platform
161+
platform == :ios
162162
end
163163
end
164164
end

lib/fastlane/plugin/wpmreleasetoolkit/helper/app_size_metrics_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def send_metrics(to:, api_token:, use_gzip: true)
5959

6060
# Allow using a `file:` URI for debugging
6161
if uri.is_a?(URI::File)
62-
UI.message("Writing metrics payload to file #{uri.path} (instead of sending it to a server)")
62+
UI.message("Writing metrics payload to file #{uri.path} (instead of sending it to a remote API endpoint)")
6363
File.write(uri.path, json_payload)
6464
return 201 # To make it easy at call site to check for pseudo-status code 200 even in non-HTTP cases
6565
end

0 commit comments

Comments
 (0)