Merge pull request #276 from wordpress-mobile/fix/broken-plugin_root-for-promo-screenshots

Fix a bug in the `plugin_root` method

Author: jkmassel

CHANGELOG.md

@@ -14,7 +14,7 @@ _None_
 
 ### Bug Fixes
 
-_None_
+Fixes a bug that was breaking the `promo_screenshots` helper [#276]
 
 ### Internal Changes
 

lib/fastlane/plugin/wpmreleasetoolkit/helper/filesystem_helper.rb

@@ -36,7 +36,9 @@ def self.plugin_root
         while continue
           child_filenames = dir.children.map! { |x| File.basename(x) }
 
-          if child_filenames.include? 'fastlane-plugin-wpmreleasetoolkit.gemspec'
+          # The first case is for development – where the `.gemspec` is present in the project root
+          # The second case is for production – where there's no `.gemspec`, but the root dir of the plugin is named `fastlane-plugin-wpmreleasetoolkit-{version}`.
+          if child_filenames.include?('fastlane-plugin-wpmreleasetoolkit.gemspec') || File.basename(dir).start_with?('fastlane-plugin-wpmreleasetoolkit-')
             continue = false
           else
             dir = dir.parent