Skip to content

Commit 281c181

Browse files
committed
Use better rspec descriptions
1 parent 5610731 commit 281c181

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spec/upload_to_s3_spec.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def stub_s3_response_for_file(key, exists = true)
1616
.and_return(Aws::S3::Types::HeadObjectOutput.new(content_length: content_length))
1717
end
1818

19-
describe 'uploading a file' do
19+
describe 'uploading a file with valid parameters' do
2020
it 'generates a prefix for the key by default' do
2121
expected_key = '939c39398db2405e791e205778ff70f85dff620e/a8c-key1'
2222
stub_s3_response_for_file(expected_key, exists: false)
@@ -107,7 +107,9 @@ def stub_s3_response_for_file(key, exists = true)
107107
expect(Fastlane::Actions.lane_context[Fastlane::Actions::SharedValues::S3_UPLOADED_FILE_PATH]).to eq(expected_key)
108108
end
109109
end
110+
end
110111

112+
describe 'uploading a file with invalid parameters' do
111113
it 'fails if bucket is empty or nil' do
112114
expect do
113115
with_tmp_file_path do |file_path|

0 commit comments

Comments
 (0)