File tree Expand file tree Collapse file tree 1 file changed +10
-6
lines changed Expand file tree Collapse file tree 1 file changed +10
-6
lines changed Original file line number Diff line number Diff line change 26
26
]
27
27
)
28
28
29
- # Notice the extra indentation in the library strings. The action doesn't
30
- # modify the app's strings content indentation, but it applies its own
31
- # standard to the values read from the given library strings
32
29
expected = <<~XML
33
30
<string name="a_string">test from app</string>
34
- <string name="a_lib1_string">test from lib 1</string>
35
- <string name="a_lib2_string">test from lib 2</string>
31
+ <string name="a_lib1_string">test from lib 1</string>
32
+ <string name="a_lib2_string">test from lib 2</string>
36
33
XML
37
34
expect ( File . read ( app_strings_path ) ) . to eq ( android_xml_with_content ( expected ) )
38
35
end
39
36
end
40
37
end
41
38
42
39
def android_xml_with_content ( content )
40
+ # Under the hood, the code hardcodes the generated XML indentation as 4
41
+ # spaces. Let's "force" it to be the same in here for consistency.
42
+ #
43
+ # See
44
+ # https://github.com/wordpress-mobile/release-toolkit/blob/da405f2c5ca90d696857ba2ad01da2753daa60dc/lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_localize_helper.rb#L67
45
+ default_indentation = ' ' * 4
46
+
43
47
# I couldn't find a way to interpolate a multiline string preserving its
44
48
# indentation in the heredoc below, so I hacked the following transformation
45
49
# of the input that adds the desired indentation to all lines.
46
- indented_content = content . chomp . lines . map { |l | " #{ l } " } . join
50
+ indented_content = content . chomp . lines . map { |l | "#{ default_indentation } #{ l } " } . join
47
51
48
52
return <<~XML
49
53
<?xml version="1.0" encoding="UTF-8"?>
You can’t perform that action at this time.
0 commit comments