Skip to content

Commit 27c20dc

Browse files
committed
Fix Issues Pointed on PR Review
1 parent f41bcc7 commit 27c20dc

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
### Breaking Changes
88

9-
- Deprecate the use of `GHHELPER_ACCESS` in favor of `GITHUB_TOKEN` as the default environment variable to set the GitHub API token. [#420]
9+
- Removed support for the deprecated `GHHELPER_ACCESS` in favor of `GITHUB_TOKEN` as the default environment variable to set the GitHub API token. [#420]
1010
- The `github_client:` parameter (aka `ConfigItem`) is now mandatory for all Fastlane actions that use the GitHub API. [#420]
1111
- The Fastlane action `comment_on_pr` has the parameter `access_key:` replaced by `github_token:`. [#420]
1212

spec/github_helper_spec.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,8 @@ def mock_comment(body: '<!-- REUSE_ID: test-id --> Test', user_id: 1234)
143143
)
144144
end
145145

146-
before do
147-
allow(Octokit::Client).to receive(:new).and_return(client)
148-
end
149-
150146
it 'properly passes the token all the way down to the Octokit::Client' do
147+
allow(Octokit::Client).to receive(:new).and_return(client)
151148
expect(Octokit::Client).to receive(:new).with(access_token: 'Fake-GitHubToken-123')
152149
described_class.new(github_token: 'Fake-GitHubToken-123')
153150
end
@@ -273,7 +270,7 @@ def create_milestone(need_submission:, milestone_duration:, days_code_freeze:)
273270
create_release
274271
end
275272

276-
it 'upload the assets to the correct location' do
273+
it 'uploads the assets to the correct location' do
277274
test_assets = 'test-file.xml'
278275
test_url = '/test/url'
279276

0 commit comments

Comments
 (0)