Skip to content

Commit 1f43c4c

Browse files
author
Rynaard Burger
committed
Resolve merge conflicts
2 parents f99c55e + 3ee6cd7 commit 1f43c4c

File tree

66 files changed

+382
-232
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+382
-232
lines changed

.rubocop.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,21 @@ Style/AsciiComments:
4848
# which would be incorrect and not what we want
4949
Style/StringConcatenation:
5050
Enabled: false
51+
52+
# This rule was enforced after upgrading Rubocop from `1.22.1` to `1.50.2`. We are disabling this rule for the
53+
# time being so that we don't see any unexpected behavior when running Release Toolkit actions that could be
54+
# changed by this rule. See https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569629
55+
# for more discussion
56+
Style/FetchEnvVar:
57+
Enabled: false
58+
59+
########## Gemspec Rules
60+
61+
# This was turned on by default after updating Rubocop to `1.50.2`. We want to disable this for now because
62+
# all the gem publishing is done within CI and doesn't allow for user input such as an MFA code. See
63+
# https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569313 for more discussion
64+
Gemspec/RequireMFA:
65+
Enabled: false
5166

5267
########## Metrics / Max Lengths Rules
5368

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ _None_
1010

1111
### New Features
1212

13+
- Add `ios_get_build_number` action to get the current build number from an `xcconfig` file. [#458]
1314
- Add new `android_generate_apk_from_aab` action to generate an APK from a given AAB.
1415

1516
### Bug Fixes
@@ -21,6 +22,11 @@ _None_
2122
- Add "Mobile Secrets" to `configure_update` current branch message to clarify which repo it's referring to. [#455]
2223
- `buildkite_trigger_build` now prints the web URL of the newly scheduled build, to allow you to easily open it via cmd-click. [#460]
2324
- Add the branch information to the 'This is not a release branch' error that's thrown from complete code freeze lane. [#461]
25+
- Update `octokit` to `5.6.1` This is a major version bump from version `4.18`, but is not a breaking change for the Release Toolkit because it doesn't change any public APIs for clients. [#464]
26+
- Update `danger` to `9.3.0`. This is an internal-only change and is not a breaking change for clients. [#464]
27+
- Replace `rspec-buildkite-analytics` with `buildkite-test_collector` (Buildkite renamed the gem) and update it to `2.2.0`. This is another internal-only change and is not a breaking change for clients. [#465]
28+
- Adds `ignore_pipeline_branch_filters=true` parameter to the API call triggering a Buildkite build [#468]
29+
- Replace all instances of `is_string` with `type` [#469]
2430

2531
## 7.0.0
2632

Dangerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ end
3232

3333
# Lint with Rubocop and report violations inline in GitHub
3434
github.dismiss_out_of_range_messages # This way, fixed violations should go
35-
renaming_map = (git.renamed_files || []).map { |e| [e[:before], e[:after]] }.to_h # when files are renamed, git.modified_files contains old name, not new one, so we need to do the convertion
35+
renaming_map = (git.renamed_files || []).to_h { |e| [e[:before], e[:after]] } # when files are renamed, git.modified_files contains old name, not new one, so we need to do the convertion
3636
rubocop.lint(
3737
files: git.added_files + (git.modified_files.map { |f| renaming_map[f] || f }) - git.deleted_files,
3838
inline_comment: true,

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ source('https://rubygems.org')
22

33
gemspec
44

5-
gem 'danger', '~> 8.0'
5+
gem 'danger', '~> 9.3'
66
gem 'danger-rubocop', '~> 0.6'
77

88
gem 'codecov', require: false
99
gem 'webmock', require: false
1010
gem 'yard'
1111

12-
gem 'rspec-buildkite-analytics', '~> 0.8.1'
12+
gem 'buildkite-test_collector', '~> 2.2'

0 commit comments

Comments
 (0)