Skip to content

Commit 1668708

Browse files
authored
Merge pull request #337 from wordpress-mobile/remove-deprecated-actions
Remove deprecated, unused actions
2 parents 80f78d9 + ac57799 commit 1668708

17 files changed

+1
-684
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ _None_
2626

2727
* Removes the `drawText` binary from the gem (instead depending on it being installed via `brew`). Because this update can not be safely applied with no side effects, it's considered a breaking change. [#312]
2828
* When doing Git operations, if no branch is provided, we'll use `trunk` as a default instead of `develop` [#335]
29+
* Remove deprecated `android_merge_translators_strings`, `android_update_metadata`, and `ios_merge_translators_strings` actions [#337]
2930

3031
### New Features
3132

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb

Lines changed: 0 additions & 106 deletions
This file was deleted.

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_metadata.rb

Lines changed: 0 additions & 52 deletions
This file was deleted.

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb

Lines changed: 0 additions & 101 deletions
This file was deleted.

lib/fastlane/plugin/wpmreleasetoolkit/helper/android/android_git_helper.rb

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,26 +27,6 @@ def self.commit_version_bump
2727
)
2828
end
2929
end
30-
31-
# Calls the `tools/update-translations.sh` script from the project repo, then lint them using the provided gradle task
32-
#
33-
# Deprecated. Use the `android_download_translations` action instead.
34-
#
35-
# @env PROJECT_ROOT_FOLDER The path to the git root of the project
36-
# @env PROJECT_NAME The name of the directory containing the project code (especially containing the `build.gradle` file)
37-
#
38-
# @param [String] validate_translation_command The name of the gradle task to run to validate the translations
39-
#
40-
# @todo Remove this once every client has migrated to `android_download_translations` and we got rid of that legacy action.
41-
#
42-
def self.update_metadata(validate_translation_command)
43-
Action.sh('./tools/update-translations.sh')
44-
Action.sh('git', 'submodule', 'update', '--init', '--recursive')
45-
Action.sh('./gradlew', validate_translation_command)
46-
47-
res_dir = File.join(ENV['PROJECT_ROOT_FOLDER'], ENV['PROJECT_NAME'], 'src', 'main', 'res')
48-
Fastlane::Helper::GitHelper.commit(message: 'Update translations', files: res_dir, push: true)
49-
end
5030
end
5131
end
5232
end

spec/android_merge_translators_strings_spec.rb

Lines changed: 0 additions & 85 deletions
This file was deleted.

0 commit comments

Comments
 (0)