Skip to content

Commit 1542e02

Browse files
committed
GithubHelper: Add Hash-Conversion operator to update_milestone
The change was done to make the method signature cleaner to call
1 parent 04cfc68 commit 1542e02

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/close_milestone_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def self.run(params)
1515

1616
UI.user_error!("Milestone #{milestone_title} not found.") if milestone.nil?
1717

18-
github_helper.update_milestone(repository: repository, number: milestone[:number], options: { state: 'closed' })
18+
github_helper.update_milestone(repository: repository, number: milestone[:number], state: 'closed')
1919
end
2020

2121
def self.description

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/setfrozentag_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def self.run(params)
2929
end
3030

3131
UI.message("New milestone: #{mile_title}")
32-
github_helper.update_milestone(repository: repository, number: milestone[:number], options: { title: mile_title })
32+
github_helper.update_milestone(repository: repository, number: milestone[:number], title: mile_title)
3333
end
3434

3535
def self.is_frozen(milestone)

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def comment_on_pr(project_slug:, pr_number:, body:, reuse_identifier: SecureRand
189189
# @return [Milestone] A single milestone object
190190
# @see http://developer.github.com/v3/issues/milestones/#update-a-milestone
191191
#
192-
def update_milestone(repository:, number:, options:)
192+
def update_milestone(repository:, number:, **options)
193193
client.update_milestone(repository, number, options)
194194
end
195195

0 commit comments

Comments
 (0)