Merge pull request #494 from wordpress-mobile/fix/rubocop-violations

Fix Rubocop violations

Author: spencertransier

.rubocop_todo.yml

@@ -133,21 +133,21 @@ def self.available_options
                                        description: 'The path of the .po file to update',
                                        type: String,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && (!value.empty?)
+                                         UI.user_error!("No .po file path for UpdateMetadataSourceAction given, pass using `po_file_path: 'file path'`") unless value && !value.empty?
                                          UI.user_error!("Couldn't find file at path '#{value}'") unless File.exist?(value)
                                        end),
           FastlaneCore::ConfigItem.new(key: :release_version,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_RELEASE_VERSION',
                                        description: 'The release version of the app (to use to mark the release notes)',
                                        verify_block: proc do |value|
-                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && (!value.empty?)
+                                         UI.user_error!("No relase version for UpdateMetadataSourceAction given, pass using `release_version: 'version'`") unless value && !value.empty?
                                        end),
           FastlaneCore::ConfigItem.new(key: :source_files,
                                        env_name: 'FL_UPDATE_METADATA_SOURCE_SOURCE_FILES',
                                        description: 'The hash with the path to the source files and the key to use to include their content',
                                        type: Hash,
                                        verify_block: proc do |value|
-                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && (!value.empty?)
+                                         UI.user_error!("No source file hash for UpdateMetadataSourceAction given, pass using `source_files: 'source file hash'`") unless value && !value.empty?
                                        end),
         ]
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_update_metadata_source_action.rb

@@ -12,7 +12,7 @@ def self.run(params)
         source_diff = nil
         if diff_url.nil? == false
           data = open(params[:diff_url])
-          source_diff = data.read()
+          source_diff = data.read
         end
 
         any_error = false

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/an_validate_lib_strings_action.rb

@@ -42,7 +42,7 @@ def self.run(params)
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         # Return the current version
         [next_beta_version, next_alpha_version]

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_betabuild_prechecks.rb

@@ -7,7 +7,7 @@ def self.run(params)
 
         UI.user_error!("Can't build beta and final at the same time!") if params[:final] && params[:beta]
 
-        Fastlane::Helper::GitHelper.ensure_on_branch!('release') unless other_action.is_ci()
+        Fastlane::Helper::GitHelper.ensure_on_branch!('release') unless other_action.is_ci
 
         message = ''
         beta_version = Fastlane::Helper::Android::VersionHelper.get_release_version unless !params[:beta] && !params[:final]
@@ -26,7 +26,7 @@ def self.run(params)
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean() unless other_action.is_ci()
+        other_action.ensure_git_status_clean unless other_action.is_ci
       end
 
       #####################################################

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_build_prechecks.rb

@@ -25,7 +25,7 @@ def self.run(params)
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version_beta, new_version_alpha)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
       end
 
       #####################################################

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_beta.rb

@@ -23,7 +23,7 @@ def self.run(params)
         Fastlane::Helper::Android::VersionHelper.update_versions(final_version, current_version_alpha)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
       end
 
       #####################################################

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_final_release.rb

@@ -21,7 +21,7 @@ def self.run(params)
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version, nil)
         UI.message 'Done!'
 
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
 
         UI.message 'Done.'
       end

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_hotfix.rb

@@ -36,7 +36,7 @@ def self.run(params)
 
         UI.message 'Updating app version...'
         Fastlane::Helper::Android::VersionHelper.update_versions(new_version_beta, new_version_alpha)
-        Fastlane::Helper::Android::GitHelper.commit_version_bump()
+        Fastlane::Helper::Android::GitHelper.commit_version_bump
         UI.message 'Done.'
       end
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_bump_version_release.rb

@@ -1,8 +1,8 @@
 module Fastlane
   module Actions
     class AndroidCodefreezePrechecksAction < Action
-      VERSION_RELEASE = 'release'
-      VERSION_ALPHA = 'alpha'
+      VERSION_RELEASE = 'release'.freeze
+      VERSION_ALPHA = 'alpha'.freeze
 
       def self.run(params)
         # fastlane will take care of reading in the parameter and fetching the environment variable:
@@ -33,7 +33,7 @@ def self.run(params)
         end
 
         # Check local repo status
-        other_action.ensure_git_status_clean()
+        other_action.ensure_git_status_clean
 
         # Return the current version
         Fastlane::Helper::Android::VersionHelper.get_public_version