Skip to content

Commit 044d9f7

Browse files
authored
Clarify expectation on XML indentation in AnLocalizeLibsAction spec
2 parents b533fe2 + 945119d commit 044d9f7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

spec/an_localize_libs_action_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,10 @@
2626
]
2727
)
2828

29-
# Notice the extra indentation in the library strings. The action doesn't
30-
# modify the app's strings content indentation, but it applies its own
31-
# standard to the values read from the given library strings
3229
expected = <<~XML
3330
<string name="a_string">test from app</string>
34-
<string name="a_lib1_string">test from lib 1</string>
35-
<string name="a_lib2_string">test from lib 2</string>
31+
<string name="a_lib1_string">test from lib 1</string>
32+
<string name="a_lib2_string">test from lib 2</string>
3633
XML
3734
expect(File.read(app_strings_path)).to eq(android_xml_with_content(expected))
3835
end
@@ -43,7 +40,10 @@ def android_xml_with_content(content)
4340
# I couldn't find a way to interpolate a multiline string preserving its
4441
# indentation in the heredoc below, so I hacked the following transformation
4542
# of the input that adds the desired indentation to all lines.
46-
indented_content = content.chomp.lines.map { |l| " #{l}" }.join
43+
#
44+
# The desired indentation is 4 spaces to stay aligned with the production
45+
# code applies when merging the XMLs.
46+
indented_content = content.chomp.lines.map { |l| " #{l}" }.join
4747

4848
return <<~XML
4949
<?xml version="1.0" encoding="UTF-8"?>

0 commit comments

Comments
 (0)