Skip to content

Commit ba542ba

Browse files
authored
Add auto-suggested featured image back (#831)
2 parents cd1458b + bad387c commit ba542ba

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

Package.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ let package = Package(
1111
targets: [
1212
.binaryTarget(
1313
name: "WordPressKit",
14-
url: "https://github.com/user-attachments/files/18570063/WordPressKit.zip",
15-
checksum: "fc25d3065e80af713dac970db7ed89ff37e4cc98afc98b6a2ecf7b47b2ddd0c1"
14+
url: "https://github.com/user-attachments/files/19034191/WordPressKit.zip",
15+
checksum: "34f108cba86b5e4334d1c9af79946dbb8b665e270bdd14bc8f7bc0ba7a898583"
1616
),
1717
]
1818
)

Sources/WordPressKit/Models/RemoteReaderPost.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
@property (nonatomic, strong) NSNumber *commentCount;
1818
@property (nonatomic) BOOL commentsOpen;
1919
@property (nonatomic, strong) NSString *featuredImage;
20+
@property (nonatomic, strong) NSString *autoSuggestedFeaturedImage;
21+
@property (nonatomic, strong) NSString *suitableImageFromPostContent;
2022
@property (nonatomic, strong) NSNumber *feedID;
2123
@property (nonatomic, strong) NSNumber *feedItemID;
2224
@property (nonatomic, strong) NSString *globalID;

Sources/WordPressKit/Models/RemoteReaderPost.m

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ - (instancetype)initWithDictionary:(NSDictionary *)dict;
109109
self.content = [self postContentFromPostDictionary:dict];
110110
self.date_created_gmt = [self stringOrEmptyString:[dict stringForKey:PostRESTKeyDate]];
111111
self.featuredImage = [self featuredImageFromPostDictionary:dict];
112+
self.autoSuggestedFeaturedImage = [self sanitizeFeaturedImageString:[self featuredMediaImageFromPostDictionary:dict]];
113+
self.suitableImageFromPostContent = [self sanitizeFeaturedImageString:[self suitableImageFromPostContent:dict]];
112114
self.feedID = [dict numberForKey:PostRESTKeyFeedID];
113115
self.feedItemID = [dict numberForKey:PostRESTKeyFeedItemID];
114116
self.globalID = [self stringOrEmptyString:[dict stringForKey:PostRESTKeyGlobalID]];

Sources/WordPressKit/Services/CommentServiceRemoteREST.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*/
3131
- (void)updateCommentWithID:(NSNumber * _Nonnull)commentID
3232
content:(NSString * _Nonnull)content
33-
success:(void (^ _Nullable)(void))success
33+
success:(void (^ _Nullable)(RemoteComment * _Nullable comment))success
3434
failure:(void (^ _Nullable)(NSError * _Nullable error))failure;
3535

3636
/**

Sources/WordPressKit/Services/CommentServiceRemoteREST.m

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ - (void)syncHierarchicalCommentsForPost:(NSNumber *)postID
246246

247247
- (void)updateCommentWithID:(NSNumber *)commentID
248248
content:(NSString *)content
249-
success:(void (^)(void))success
249+
success:(void (^)(RemoteComment *comment))success
250250
failure:(void (^)(NSError *error))failure
251251
{
252252
NSString *path = [NSString stringWithFormat:@"sites/%@/comments/%@", self.siteID, commentID];
@@ -260,14 +260,15 @@ - (void)updateCommentWithID:(NSNumber *)commentID
260260
[self.wordPressComRESTAPI post:requestUrl
261261
parameters:parameters
262262
success:^(id responseObject, NSHTTPURLResponse *httpResponse) {
263-
if (success) {
264-
success();
265-
}
266-
} failure:^(NSError *error, NSHTTPURLResponse *httpResponse) {
267-
if (failure) {
268-
failure(error);
269-
}
270-
}];
263+
RemoteComment *comment = [self remoteCommentFromJSONDictionary:responseObject];
264+
if (success) {
265+
success(comment);
266+
}
267+
} failure:^(NSError *error, NSHTTPURLResponse *httpResponse) {
268+
if (failure) {
269+
failure(error);
270+
}
271+
}];
271272
}
272273

273274
- (void)replyToPostWithID:(NSNumber *)postID

Tests/WordPressKitTests/Tests/RemoteReaderPostTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ - (void)testFeaturedImageFromDictionary {
209209
uri, uri, uri]
210210
};
211211
imagePath = [remoteReaderPost featuredImageFromPostDictionary:dict];
212-
XCTAssertTrue([uri isEqualToString:imagePath], @"Failed to retrieve the image uri from the post content.");
212+
XCTAssertTrue(imagePath.length == 0, @"No image should be retrieved from the content");
213213

214214
dict = [self editorialDictionaryWithKey:@"image" value:uri];
215215
imagePath = [remoteReaderPost featuredImageFromPostDictionary:dict];

0 commit comments

Comments
 (0)