Fix crash due to an unregistered cell in Stats Insights (#18613)

Author: mokagio

RELEASE-NOTES.txt

@@ -13,6 +13,7 @@
 * [*] Block Editor: Gallery block: Fix broken "Link To" settings and add "Image Size" settings [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4841]
 * [*] Block Editor: Unsupported Block Editor: Prevent WordPress.com tour banner from displaying. [https://github.com/wordpress-mobile/gutenberg-mobile/pull/4820]
 * [*] Widgets: we fixed an issue where text appeared flipped in rtl languages [#18567]
+* [*] Stats: we fixed a crash that occurred sometimes in Stats [#18613]
 * [*] Posts list: we fixed an issue where the create button was not shown on iPad in split screen [#18609]
 
 19.8

WordPress/Classes/ViewRelated/Stats/Insights/InsightType.swift

@@ -1,7 +1,6 @@
 import Foundation
 
 enum InsightType: Int, SiteStatsPinnable {
-    case viewsVisitors
     case growAudience
     case customize
     case latestPostSummary
@@ -20,6 +19,7 @@ enum InsightType: Int, SiteStatsPinnable {
     case allComments
     case allTagsAndCategories
     case allAnnual
+    case viewsVisitors
 
     // These Insights will be displayed in this order if a site's Insights have not been customized.
     static let defaultInsights: [InsightType] = [.mostPopularTime,

WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

@@ -172,29 +172,8 @@ private extension SiteStatsInsightsTableViewController {
     }
 
     func tableRowTypes() -> [ImmuTableRow.Type] {
-        if FeatureFlag.statsNewInsights.enabled {
-            return [InsightCellHeaderRow.self,
-                    ViewsVisitorsRow.self,
-                    GrowAudienceRow.self,
-                    CustomizeInsightsRow.self,
-                    LatestPostSummaryRow.self,
-                    TwoColumnStatsRow.self,
-                    PostingActivityRow.self,
-                    TabbedTotalsStatsRow.self,
-                    TopTotalsInsightStatsRow.self,
-                    MostPopularTimeInsightStatsRow.self,
-                    TotalInsightStatsRow.self,
-                    TableFooterRow.self,
-                    StatsErrorRow.self,
-                    StatsGhostGrowAudienceImmutableRow.self,
-                    StatsGhostChartImmutableRow.self,
-                    StatsGhostTwoColumnImmutableRow.self,
-                    StatsGhostTopImmutableRow.self,
-                    StatsGhostTabbedImmutableRow.self,
-                    StatsGhostPostingActivitiesImmutableRow.self]
-        }
-
         return [InsightCellHeaderRow.self,
+                ViewsVisitorsRow.self,
                 GrowAudienceRow.self,
                 CustomizeInsightsRow.self,
                 LatestPostSummaryRow.self,