Refactor: use same constant in WPAnalytics helpers and PushNotificationsManager

hassaanelgarem · hassaanelgarem · commit c4aacb02f167 · 2022-05-11T06:48:42.000+02:00
diff --git a/WordPress/Classes/Utility/Analytics/WPAnalytics+QuickStart.swift b/WordPress/Classes/Utility/Analytics/WPAnalytics+QuickStart.swift
@@ -2,7 +2,7 @@ import Foundation
 
 extension WPAnalytics {
 
-    private static let WPAppAnalyticsKeyQuickStartSiteType: String = "site_type"
+    static let WPAppAnalyticsKeyQuickStartSiteType: String = "site_type"
 
     /// Track a Quick Start event
     ///
diff --git a/WordPress/Classes/Utility/PushNotificationsManager.swift b/WordPress/Classes/Utility/PushNotificationsManager.swift
@@ -431,7 +431,7 @@ extension PushNotificationsManager {
             let quickStartType = userInfo.string(forKey: QuickStartTracking.quickStartTypeKey) {
             WPAnalytics.track(.quickStartNotificationTapped,
                               withProperties: [QuickStartTracking.taskNameKey: taskName,
-                                               QuickStartTracking.quickStartTypeKey: quickStartType])
+                                               WPAnalytics.WPAppAnalyticsKeyQuickStartSiteType: quickStartType])
         }
 
         completionHandler?(.newData)
@@ -462,7 +462,7 @@ extension PushNotificationsManager {
 
         WPAnalytics.track(.quickStartNotificationStarted,
                           withProperties: [QuickStartTracking.taskNameKey: tour.analyticsKey,
-                                           QuickStartTracking.quickStartTypeKey: quickStartType.key])
+                                           WPAnalytics.WPAppAnalyticsKeyQuickStartSiteType: quickStartType.key])
     }
 
     @objc func deletePendingLocalNotifications() {

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ extension PushNotificationsManager {`
`431`	`431`	`let quickStartType = userInfo.string(forKey: QuickStartTracking.quickStartTypeKey) {`
`432`	`432`	`WPAnalytics.track(.quickStartNotificationTapped,`
`433`	`433`	`withProperties: [QuickStartTracking.taskNameKey: taskName,`
`434`		`- QuickStartTracking.quickStartTypeKey: quickStartType])`
	`434`	`+ WPAnalytics.WPAppAnalyticsKeyQuickStartSiteType: quickStartType])`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`completionHandler?(.newData)`
`@@ -462,7 +462,7 @@ extension PushNotificationsManager {`
`462`	`462`
`463`	`463`	`WPAnalytics.track(.quickStartNotificationStarted,`
`464`	`464`	`withProperties: [QuickStartTracking.taskNameKey: tour.analyticsKey,`
`465`		`- QuickStartTracking.quickStartTypeKey: quickStartType.key])`
	`465`	`+ WPAnalytics.WPAppAnalyticsKeyQuickStartSiteType: quickStartType.key])`
`466`	`466`	`}`
`467`	`467`
`468`	`468`	`@objc func deletePendingLocalNotifications() {`