Skip to content

Commit 9f10ae7

Browse files
author
Momo Ozawa
committed
Refactor: apply insets to MySiteVC if MSD is enabled
1 parent 21b95e1 commit 9f10ae7

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController+FancyAlerts.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,13 @@ extension BlogDetailsViewController {
2323
if let info = notification.userInfo?[QuickStartTourGuide.notificationElementKey] as? QuickStartTourElement {
2424
switch info {
2525
case .noSuchElement:
26-
self?.additionalSafeAreaInsets = UIEdgeInsets.zero
26+
if FeatureFlag.mySiteDashboard.enabled,
27+
let parentVC = self?.parent as? MySiteViewController {
28+
parentVC.additionalSafeAreaInsets = UIEdgeInsets.zero
29+
} else {
30+
self?.additionalSafeAreaInsets = UIEdgeInsets.zero
31+
}
32+
2733
case .siteIcon, .siteTitle:
2834
// handles the padding in case the element is not in the table view
2935
self?.additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: BlogDetailsViewController.bottomPaddingForQuickStartNotices, right: 0)

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -421,9 +421,23 @@ - (void)viewWillAppear:(BOOL)animated
421421
[super viewWillAppear:animated];
422422

423423
if ([[QuickStartTourGuide shared] currentElementInt] != NSNotFound) {
424-
self.additionalSafeAreaInsets = UIEdgeInsetsMake(0, 0, [BlogDetailsViewController bottomPaddingForQuickStartNotices], 0);
424+
425+
if ([Feature enabled:FeatureFlagMySiteDashboard]) {
426+
MySiteViewController *parentVC = (MySiteViewController *)self.parentViewController;
427+
parentVC.additionalSafeAreaInsets = UIEdgeInsetsMake(0, 0, [BlogDetailsViewController bottomPaddingForQuickStartNotices], 0);
428+
} else {
429+
self.additionalSafeAreaInsets = UIEdgeInsetsMake(0, 0, [BlogDetailsViewController bottomPaddingForQuickStartNotices], 0);
430+
}
431+
425432
} else {
426-
self.additionalSafeAreaInsets = UIEdgeInsetsZero;
433+
434+
if ([Feature enabled:FeatureFlagMySiteDashboard]) {
435+
MySiteViewController *parentVC = (MySiteViewController *)self.parentViewController;
436+
parentVC.additionalSafeAreaInsets = UIEdgeInsetsZero;
437+
} else {
438+
self.additionalSafeAreaInsets = UIEdgeInsetsZero;
439+
}
440+
427441
}
428442

429443
if (self.splitViewControllerIsHorizontallyCompact) {
@@ -1922,7 +1936,12 @@ - (void)showViewSiteFromSource:(BlogDetailsNavigationSource)source
19221936
[[QuickStartTourGuide shared] completeViewSiteTourForBlog:self.blog];
19231937
}
19241938

1925-
self.additionalSafeAreaInsets = UIEdgeInsetsZero;
1939+
if ([Feature enabled:FeatureFlagMySiteDashboard]) {
1940+
MySiteViewController *parentVC = (MySiteViewController *)self.parentViewController;
1941+
parentVC.additionalSafeAreaInsets = UIEdgeInsetsZero;
1942+
} else {
1943+
self.additionalSafeAreaInsets = UIEdgeInsetsZero;
1944+
}
19261945
}
19271946

19281947
- (void)showViewAdmin

WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController+QuickStart.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ extension SitePickerViewController {
2525
self?.additionalSafeAreaInsets = UIEdgeInsets.zero
2626
case .siteIcon, .siteTitle:
2727
// handles the padding in case the element is not in the table view
28-
self?.additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: BlogDetailsViewController.bottomPaddingForQuickStartNotices, right: 0)
28+
guard let parentVC = self?.parent as? MySiteViewController else {
29+
return
30+
}
31+
parentVC.additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: BlogDetailsViewController.bottomPaddingForQuickStartNotices, right: 0)
2932
default:
3033
break
3134
}

WordPress/Classes/ViewRelated/Blog/Site Picker/SitePickerViewController.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,10 @@ extension SitePickerViewController {
242242
tourGuide.completeViewSiteTour(forBlog: blog)
243243
}
244244

245-
additionalSafeAreaInsets = .zero
245+
guard let parentVC = parent as? MySiteViewController else {
246+
return
247+
}
248+
parentVC.additionalSafeAreaInsets = .zero
246249
}
247250
}
248251

0 commit comments

Comments
 (0)