Merge pull request #18525 from wordpress-mobile/tooling/AppLocalizedString-linter-v2

[Tooling] Improvements on the AppLocalizedString linter

Author: AliSoftware

Scripts/BuildPhases/LintAppLocalizedStringsUsage.sh

@@ -8,10 +8,14 @@ LINTER_EXEC="${LINTER_BUILD_DIR}/$(basename "${SCRIPT_SRC}" .swift)"
 
 if [ ! -x "${LINTER_EXEC}" ] || ! (shasum -c "${LINTER_EXEC}.shasum" >/dev/null 2>/dev/null); then
   echo "Pre-compiling linter script to ${LINTER_EXEC}..."
-  swiftc -sdk "$(xcrun --sdk macosx --show-sdk-path)" "${SCRIPT_SRC}" -o "${LINTER_EXEC}"
+  swiftc -O -sdk "$(xcrun --sdk macosx --show-sdk-path)" "${SCRIPT_SRC}" -o "${LINTER_EXEC}"
   shasum "${SCRIPT_SRC}" >"${LINTER_EXEC}.shasum"
   chmod +x "${LINTER_EXEC}"
   echo "Pre-compiled linter script ready"
 fi
 
-"$LINTER_EXEC" "${PROJECT_FILE_PATH:-$1}" # "${TARGET_NAME:-$2}"
+if [ -z "${PROJECT_FILE_PATH:=${1:-}}" ]; then
+  echo "error: Please provide the path to the xcodeproj to scan"
+  exit 1
+fi
+"$LINTER_EXEC" "${PROJECT_FILE_PATH}" "${@:2}"