Skip to content

Commit 6430e00

Browse files
Merge pull request #18590 from wordpress-mobile/issue/18565-qs-modify-reader-tour
QuickStart for Existing Users V2: Mark reader task as done when user taps on a tag
2 parents c16c4fc + 3c76b21 commit 6430e00

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

WordPress/Classes/ViewRelated/Reader/Select Interests/ReaderSelectInterestsViewController.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,9 @@ extension ReaderSelectInterestsViewController: UICollectionViewDelegate {
344344
spotlightIsShown = false
345345
}
346346

347+
// End reader quick start tour if user selects a topic.
348+
QuickStartTourGuide.shared.visited(.readerDiscoverSettings)
349+
347350
dataSource.interest(for: indexPath.row).toggleSelected()
348351
updateNextButtonState()
349352

WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabViewController.swift

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class ReaderTabViewController: UIViewController {
3838

3939
NotificationCenter.default.addObserver(self, selector: #selector(defaultAccountDidChange(_:)), name: NSNotification.Name.WPAccountDefaultWordPressComAccountChanged, object: nil)
4040
NotificationCenter.default.addObserver(self, selector: #selector(willEnterForeground), name: UIApplication.willEnterForegroundNotification, object: nil)
41+
startObservingQuickStart()
4142

4243
viewModel.fetchReaderMenu()
4344
}
@@ -123,7 +124,6 @@ class ReaderTabViewController: UIViewController {
123124
// MARK: - Navigation Buttons
124125
extension ReaderTabViewController {
125126
@objc private func didTapSettingsButton() {
126-
settingsButton.shouldShowSpotlight = false
127127
viewModel.presentManage(from: self)
128128
}
129129

@@ -132,6 +132,18 @@ extension ReaderTabViewController {
132132
}
133133
}
134134

135+
// MARK: Observing Quick Start
136+
extension ReaderTabViewController {
137+
private func startObservingQuickStart() {
138+
NotificationCenter.default.addObserver(forName: .QuickStartTourElementChangedNotification, object: nil, queue: nil) { [weak self] notification in
139+
if let info = notification.userInfo,
140+
let element = info[QuickStartTourGuide.notificationElementKey] as? QuickStartTourElement {
141+
self?.settingsButton.shouldShowSpotlight = element == .readerDiscoverSettings
142+
}
143+
}
144+
}
145+
}
146+
135147

136148
// MARK: - State Restoration
137149
extension ReaderTabViewController: UIViewControllerRestoration {

0 commit comments

Comments
 (0)