Merge pull request #17807 from wordpress-mobile/issue/12878-media-detail-improve-accessibility

Media Detail screen improve accessibility and hints

Author: sla8c

WordPress/Classes/Utility/WPImmuTableRows.swift

@@ -93,6 +93,11 @@ struct EditableTextRow: ImmuTableRow {
     func configureCell(_ cell: UITableViewCell) {
         cell.textLabel?.text = title
         cell.detailTextLabel?.text = value
+        cell.accessibilityLabel = title
+        cell.accessibilityValue = value
+        if cell.isUserInteractionEnabled {
+            cell.accessibilityHint = NSLocalizedString("Tap to edit", comment: "Accessibility hint prompting the user to tap a table row to edit its value.")
+        }
         cell.accessoryType = .disclosureIndicator
         if accessoryImage != nil {
             cell.accessoryView = UIImageView(image: accessoryImage)
@@ -129,6 +134,9 @@ struct TextRow: ImmuTableRow {
     func configureCell(_ cell: UITableViewCell) {
         cell.textLabel?.text = title
         cell.detailTextLabel?.text = value
+        cell.accessibilityLabel = title
+        cell.accessibilityValue = value
+
         cell.selectionStyle = .none
 
         WPStyleGuide.configureTableViewCell(cell)

WordPress/Classes/ViewRelated/Cells/MediaItemTableViewCells.swift

@@ -175,6 +175,9 @@ struct MediaImageRow: ImmuTableRow {
             setAspectRatioFor(cell)
             loadImageFor(cell)
             cell.isVideo = media.mediaType == .video
+            cell.accessibilityTraits = .button
+            cell.accessibilityLabel = NSLocalizedString("Preview media", comment: "Accessibility label for media item preview for user's viewing an item in their media library")
+            cell.accessibilityHint = NSLocalizedString("Tap to view media in full screen", comment: "Accessibility hint for media item preview for user's viewing an item in their media library")
         }
     }
 
@@ -239,6 +242,9 @@ struct MediaDocumentRow: ImmuTableRow {
         if let cell = cell as? MediaItemDocumentTableViewCell {
             cell.customImageView.tintColor = cell.textLabel?.textColor
             cell.showIconForMedia(media)
+            cell.accessibilityTraits = .button
+            cell.accessibilityLabel = NSLocalizedString("Preview media", comment: "Accessibility label for media item preview for user's viewing an item in their media library")
+            cell.accessibilityHint = NSLocalizedString("Tap to view media in full screen", comment: "Accessibility hint for media item preview for user's viewing an item in their media library")
         }
     }
 }