Merge pull request #14914 from wordpress-mobile/improve-gradle-configuration

Use task avoidance in build.gradle & WordPress/build.gradle

Author: oguzkocer

WordPress/build.gradle

@@ -469,7 +469,7 @@ android.buildTypes.all { buildType ->
     }
 }
 
-task violationCommentsToGitHub(type: se.bjurr.violations.comments.github.plugin.gradle.ViolationCommentsToGitHubTask) {
+tasks.register("violationCommentsToGitHub", se.bjurr.violations.comments.github.plugin.gradle.ViolationCommentsToGitHubTask) {
     repositoryOwner = "wordpress-mobile"
     repositoryName = "WordPress-Android"
     pullRequestId = System.properties['GITHUB_PULLREQUESTID']
@@ -495,7 +495,7 @@ task violationCommentsToGitHub(type: se.bjurr.violations.comments.github.plugin.
     ]
 }
 
-task printVersionName {
+tasks.register("printVersionName") {
     doLast {
         println android.productFlavors.vanilla.versionName
     }

build.gradle

@@ -48,7 +48,7 @@ allprojects {
         }
     }
 
-    task checkstyle(type: Checkstyle) {
+    tasks.register("checkstyle", Checkstyle) {
         source 'src'
 
         classpath = files()
@@ -91,19 +91,19 @@ subprojects {
         ktlint 'com.github.shyiko:ktlint:0.29.0'
     }
 
-    task ktlint(type: JavaExec) {
+    tasks.register("ktlint", JavaExec) {
         main = "com.github.shyiko.ktlint.Main"
         classpath = configurations.ktlint
         args "src/**/*.kt"
     }
 
-    task ktlintFormat(type: JavaExec) {
+    tasks.register("ktlintFormat", JavaExec) {
         main = "com.github.shyiko.ktlint.Main"
         classpath = configurations.ktlint
         args "-F", "src/**/*.kt"
     }
 
-    task ciktlint(type: JavaExec) {
+    tasks.register("ciktlint", JavaExec) {
         main = "com.github.shyiko.ktlint.Main"
         classpath = configurations.ktlint
         args "src/**/*.kt", "--reporter=checkstyle,output=${buildDir}/ktlint.xml"
@@ -158,7 +158,7 @@ ext {
 }
 
 // Onboarding and dev env setup tasks
-task checkBundler(type:Exec) {
+tasks.register("checkBundler", Exec) {
     doFirst {
         println "Check Bundler"
     }
@@ -176,7 +176,8 @@ task checkBundler(type:Exec) {
     }
 }
 
-task checkBundle(type:Exec, dependsOn:checkBundler) {
+tasks.register("checkBundle", Exec) {
+    dependsOn tasks.named("checkBundler")
     doFirst {
         println "Check Bundle"
     }
@@ -194,7 +195,8 @@ task checkBundle(type:Exec, dependsOn:checkBundler) {
     }
 }
 
-task applyCredentials(type:Exec, dependsOn:checkBundle) {
+tasks.register("applyCredentials", Exec) {
+    dependsOn tasks.named("checkBundle")
     doFirst {
         println "Apply credentials for this branch"
     }