Merge pull request #16529 from wordpress-mobile/issue/blogging-prompts-visual-fixes

Issue/blogging prompts visual fixes

Author: khaykov

WordPress/src/main/java/org/wordpress/android/ui/bloggingprompts/onboarding/BloggingPromptsOnboardingUiStateMapper.kt

@@ -21,8 +21,7 @@ class BloggingPromptsOnboardingUiStateMapper @Inject constructor() {
     ): Ready {
         val dummyRespondent = BloggingPromptRespondent(
                 54279365,
-                "https://0.gravatar.com/avatar/cec64efa352617" +
-                        "c35743d8ed233ab410?s=96&d=identicon&r=G"
+                ""
         )
 
         val dummyRespondents = listOf(

WordPress/src/main/java/org/wordpress/android/ui/mysite/cards/dashboard/bloggingprompts/BloggingPromptCardViewHolder.kt

@@ -59,22 +59,28 @@ class BloggingPromptCardViewHolder(
                 FlexDirection.ROW,
                 FlexWrap.NOWRAP
         ).apply { justifyContent = JustifyContent.CENTER }
-        answeredUsersRecycler.addItemDecoration(
-                AvatarItemDecorator(
-                        RtlUtils.isRtl(answeredUsersRecycler.context),
-                        answeredUsersRecycler.context,
-                        AVATAR_LEFT_OFFSET_DIMEN
-                )
-        )
-        answeredUsersRecycler.layoutManager = layoutManager
 
-        val adapter = TrainOfAvatarsAdapter(
-                imageManager,
-                uiHelpers
-        )
-        answeredUsersRecycler.adapter = adapter
+        if (card.numberOfAnswers > 0) {
+            uiHelpers.updateVisibility(answeredUsersRecycler, true)
+            answeredUsersRecycler.addItemDecoration(
+                    AvatarItemDecorator(
+                            RtlUtils.isRtl(answeredUsersRecycler.context),
+                            answeredUsersRecycler.context,
+                            AVATAR_LEFT_OFFSET_DIMEN
+                    )
+            )
+            answeredUsersRecycler.layoutManager = layoutManager
+
+            val adapter = TrainOfAvatarsAdapter(
+                    imageManager,
+                    uiHelpers
+            )
+            answeredUsersRecycler.adapter = adapter
 
-        adapter.loadData(card.respondents)
+            adapter.loadData(card.respondents)
+        } else {
+            uiHelpers.updateVisibility(answeredUsersRecycler, false)
+        }
     }
 }
 

WordPress/src/main/res/layout/avatar_item.xml

@@ -5,6 +5,7 @@
     android:layout_height="match_parent">
 
     <ImageView
+        android:backgroundTint="?attr/colorSurface"
         android:id="@+id/avatar"
         style="@style/ReaderImageView.Avatar.Small"
         android:layout_gravity="center_vertical"

WordPress/src/main/res/layout/blogging_promp_card_compact.xml

@@ -46,7 +46,7 @@
 
         <com.google.android.material.textview.MaterialTextView
             android:id="@+id/prompt_content"
-            style="@style/MySiteCardItemTitle"
+            style="@style/MySiteCardBloggingPromptTitle"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="@dimen/margin_large"

WordPress/src/main/res/layout/my_site_blogging_promp_card.xml

@@ -53,7 +53,7 @@
 
         <com.google.android.material.textview.MaterialTextView
             android:id="@+id/prompt_content"
-            style="@style/MySiteCardItemTitle"
+            style="@style/MySiteCardBloggingPromptTitle"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginTop="@dimen/margin_extra_large"

WordPress/src/main/res/values/styles.xml

@@ -856,6 +856,12 @@
         <item name="android:paddingEnd">@dimen/margin_medium</item>
     </style>
 
+    <style name="MySiteCardBloggingPromptTitle" parent="@style/MySiteCardItemTitle">
+        <item name="android:maxLines">3</item>
+        <item name="autoSizeTextType">uniform</item>
+        <item name="autoSizeMinTextSize">12sp</item>
+    </style>
+
     <!--People Management Styles-->
     <style name="PersonAvatar">
         <item name="android:layout_width">@dimen/people_avatar_sz</item>

WordPress/src/test/java/org/wordpress/android/ui/bloggingprompts/onboarding/BloggingPromptsOnboardingUiStateMapperTest.kt

@@ -17,18 +17,15 @@ class BloggingPromptsOnboardingUiStateMapperTest {
     private val expectedRespondents = listOf(
             AvatarItem(
                     54279365,
-                    "https://0.gravatar.com/avatar/cec64efa352617" +
-                            "c35743d8ed233ab410?s=96&d=identicon&r=G"
+                    ""
             ),
             AvatarItem(
                     54279365,
-                    "https://0.gravatar.com/avatar/cec64efa352617" +
-                            "c35743d8ed233ab410?s=96&d=identicon&r=G"
+                    ""
             ),
             AvatarItem(
                     54279365,
-                    "https://0.gravatar.com/avatar/cec64efa352617" +
-                            "c35743d8ed233ab410?s=96&d=identicon&r=G"
+                    ""
             ),
             TrailingLabelTextItem(
                     UiStringPluralRes(R.plurals.my_site_blogging_prompt_card_number_of_answers, 5),