Apply PR suggestions

Author: RenanLukas

WordPress/src/main/java/org/wordpress/android/sharedlogin/SharedLoginAnalyticsTracker.kt

@@ -8,12 +8,12 @@ import javax.inject.Inject
 class SharedLoginAnalyticsTracker @Inject constructor(
     private val analyticsTracker: AnalyticsTrackerWrapper
 ) {
-    fun trackLoginStart() = analyticsTracker.track(Stat.SHARED_LOGIN_START, emptyMap())
+    fun trackLoginStart() = analyticsTracker.track(Stat.SHARED_LOGIN_START)
 
-    fun trackLoginSuccess() = analyticsTracker.track(Stat.SHARED_LOGIN_SUCCESS, emptyMap())
+    fun trackLoginSuccess() = analyticsTracker.track(Stat.SHARED_LOGIN_SUCCESS)
 
     fun trackLoginFailed(errorType: ErrorType) =
-            analyticsTracker.track(Stat.SHARED_LOGIN_FAILED, mapOf(ERROR_TYPE to errorType))
+            analyticsTracker.track(Stat.SHARED_LOGIN_FAILED, mapOf(ERROR_TYPE to errorType.value))
 
     sealed class ErrorType(val value: String) {
         object WPNotLoggedInError : ErrorType("wp_not_logged_in_error")

WordPress/src/test/java/org/wordpress/android/sharedlogin/SharedLoginAnalyticsTrackerTest.kt

@@ -0,0 +1,43 @@
+package org.wordpress.android.sharedlogin
+
+import com.nhaarman.mockitokotlin2.mock
+import com.nhaarman.mockitokotlin2.verify
+import org.junit.Test
+import org.wordpress.android.analytics.AnalyticsTracker.Stat
+import org.wordpress.android.sharedlogin.SharedLoginAnalyticsTracker.ErrorType
+import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
+
+class SharedLoginAnalyticsTrackerTest {
+    private val analyticsTrackerWrapper: AnalyticsTrackerWrapper = mock()
+    private val classToTest = SharedLoginAnalyticsTracker(analyticsTrackerWrapper)
+
+    @Test
+    fun `Should track login start correctly`() {
+        classToTest.trackLoginStart()
+        verify(analyticsTrackerWrapper).track(Stat.SHARED_LOGIN_START)
+    }
+
+    @Test
+    fun `Should track login success correctly`() {
+        classToTest.trackLoginSuccess()
+        verify(analyticsTrackerWrapper).track(Stat.SHARED_LOGIN_SUCCESS)
+    }
+
+    @Test
+    fun `Should track login failed WPNotLoggedInError correctly`() {
+        classToTest.trackLoginFailed(ErrorType.WPNotLoggedInError)
+        verify(analyticsTrackerWrapper).track(
+                Stat.SHARED_LOGIN_FAILED,
+                mapOf("error_type" to "wp_not_logged_in_error")
+        )
+    }
+
+    @Test
+    fun `Should track login failed QueryTokenError correctly`() {
+        classToTest.trackLoginFailed(ErrorType.QueryTokenError)
+        verify(analyticsTrackerWrapper).track(
+                Stat.SHARED_LOGIN_FAILED,
+                mapOf("error_type" to "query_token_error")
+        )
+    }
+}