Merge pull request #17062 from wordpress-mobile/fix/jetpack-banner-visible-in-jetpack-app

Use Jetpack branding utils flag to set banner visibility in search

Author: mkevins

WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java

@@ -507,15 +507,15 @@ public void onCreate(Bundle savedInstanceState) {
     private void toggleJetpackBannerIfEnabled(final boolean showIfEnabled, boolean animateOnScroll) {
         if (!isAdded() || getView() == null || !isSearching()) return;
 
-        if (animateOnScroll) {
-            RecyclerView scrollView = mRecyclerView.getInternalRecyclerView();
-            mJetpackBrandingUtils.showJetpackBannerIfScrolledToTop(mJetpackBanner, scrollView);
-            mJetpackBrandingUtils.setNavigationBarColorForBanner(requireActivity().getWindow());
-            // Return early since the banner visibility was handled by showJetpackBannerIfScrolledToTop
-            return;
-        }
-
         if (mJetpackBrandingUtils.shouldShowJetpackBranding()) {
+            if (animateOnScroll) {
+                RecyclerView scrollView = mRecyclerView.getInternalRecyclerView();
+                mJetpackBrandingUtils.showJetpackBannerIfScrolledToTop(mJetpackBanner, scrollView);
+                mJetpackBrandingUtils.setNavigationBarColorForBanner(requireActivity().getWindow());
+                // Return early since the banner visibility was handled by showJetpackBannerIfScrolledToTop
+                return;
+            }
+
             if (showIfEnabled && !mDisplayUtilsWrapper.isPhoneLandscape()) {
                 showJetpackBanner();
             } else {