Skip to content

Commit 2dd86ff

Browse files
committed
Migrate LoginSiteCheckErrorFragment to Hilt
1 parent 1bb21d3 commit 2dd86ff

File tree

4 files changed

+6
-24
lines changed

4 files changed

+6
-24
lines changed

WordPress/src/main/java/org/wordpress/android/modules/AppComponent.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import org.wordpress.android.ui.accounts.HelpActivity;
1818
import org.wordpress.android.ui.accounts.PostSignupInterstitialActivity;
1919
import org.wordpress.android.ui.accounts.SignupEpilogueActivity;
20-
import org.wordpress.android.ui.accounts.login.jetpack.LoginSiteCheckErrorFragment;
2120
import org.wordpress.android.ui.accounts.signup.SignupEpilogueFragment;
2221
import org.wordpress.android.ui.activitylog.detail.ActivityLogDetailFragment;
2322
import org.wordpress.android.ui.activitylog.list.ActivityLogListFragment;
@@ -595,8 +594,6 @@ public interface AppComponent {
595594

596595
void inject(SiteSettingsTimezoneBottomSheet object);
597596

598-
void inject(LoginSiteCheckErrorFragment object);
599-
600597
void inject(UserProfileBottomSheetFragment object);
601598

602599
void inject(EngagedPeopleListActivity object);

WordPress/src/main/java/org/wordpress/android/modules/ViewModelModule.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
import org.wordpress.android.ui.JetpackRemoteInstallViewModel;
77
import org.wordpress.android.ui.accounts.LoginViewModel;
8-
import org.wordpress.android.ui.accounts.login.jetpack.LoginSiteCheckErrorViewModel;
98
import org.wordpress.android.ui.activitylog.list.filter.ActivityLogTypeFilterViewModel;
109
import org.wordpress.android.ui.bloggingprompts.onboarding.BloggingPromptsOnboardingViewModel;
1110
import org.wordpress.android.ui.bloggingreminders.BloggingRemindersViewModel;
@@ -492,11 +491,6 @@ abstract class ViewModelModule {
492491
@ViewModelKey(DeepLinkingIntentReceiverViewModel.class)
493492
abstract ViewModel deepLinkingIntentReceiverViewModel(DeepLinkingIntentReceiverViewModel viewModel);
494493

495-
@Binds
496-
@IntoMap
497-
@ViewModelKey(LoginSiteCheckErrorViewModel.class)
498-
abstract ViewModel loginSiteCheckErrorViewModel(LoginSiteCheckErrorViewModel viewModel);
499-
500494
@Binds
501495
@IntoMap
502496
@ViewModelKey(StorageUtilsViewModel.class)

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/jetpack/LoginSiteCheckErrorFragment.kt

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import android.os.Bundle
55
import android.view.View
66
import androidx.activity.OnBackPressedCallback
77
import androidx.fragment.app.Fragment
8-
import androidx.lifecycle.ViewModelProvider
8+
import androidx.fragment.app.viewModels
9+
import dagger.hilt.android.AndroidEntryPoint
910
import org.wordpress.android.R
10-
import org.wordpress.android.WordPress
1111
import org.wordpress.android.databinding.JetpackLoginEmptyViewBinding
1212
import org.wordpress.android.login.LoginListener
1313
import org.wordpress.android.ui.ActivityLauncher
@@ -19,6 +19,7 @@ import org.wordpress.android.ui.utils.HtmlMessageUtils
1919
import org.wordpress.android.util.ActivityUtils
2020
import javax.inject.Inject
2121

22+
@AndroidEntryPoint
2223
class LoginSiteCheckErrorFragment : Fragment(R.layout.jetpack_login_empty_view) {
2324
companion object {
2425
const val TAG = "LoginSiteCheckErrorFragment"
@@ -33,12 +34,11 @@ class LoginSiteCheckErrorFragment : Fragment(R.layout.jetpack_login_empty_view)
3334
}
3435
}
3536

36-
@Inject lateinit var viewModelFactory: ViewModelProvider.Factory
3737
@Inject lateinit var unifiedLoginTracker: UnifiedLoginTracker
3838
@Inject lateinit var htmlMessageUtils: HtmlMessageUtils
3939
private var loginListener: LoginListener? = null
4040
private var siteAddress: String? = null
41-
private lateinit var viewModel: LoginSiteCheckErrorViewModel
41+
private val viewModel: LoginSiteCheckErrorViewModel by viewModels()
4242

4343
override fun onCreate(savedInstanceState: Bundle?) {
4444
super.onCreate(savedInstanceState)
@@ -51,9 +51,7 @@ class LoginSiteCheckErrorFragment : Fragment(R.layout.jetpack_login_empty_view)
5151
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
5252
super.onViewCreated(view, savedInstanceState)
5353

54-
initDagger()
5554
initBackPressHandler()
56-
initViewModel()
5755
with(JetpackLoginEmptyViewBinding.bind(view)) {
5856
ActivityUtils.hideKeyboardForced(view)
5957
initErrorMessageView()
@@ -62,15 +60,6 @@ class LoginSiteCheckErrorFragment : Fragment(R.layout.jetpack_login_empty_view)
6260
initObservers()
6361
}
6462

65-
private fun initDagger() {
66-
(requireActivity().application as WordPress).component().inject(this)
67-
}
68-
69-
private fun initViewModel() {
70-
viewModel = ViewModelProvider(this@LoginSiteCheckErrorFragment, viewModelFactory)
71-
.get(LoginSiteCheckErrorViewModel::class.java)
72-
}
73-
7463
private fun JetpackLoginEmptyViewBinding.initErrorMessageView() {
7564
loginErrorMessageText.text = htmlMessageUtils.getHtmlMessageFromStringFormatResId(
7665
R.string.login_not_a_jetpack_site,

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/jetpack/LoginSiteCheckErrorViewModel.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package org.wordpress.android.ui.accounts.login.jetpack
22

33
import androidx.lifecycle.LiveData
44
import androidx.lifecycle.MediatorLiveData
5+
import dagger.hilt.android.lifecycle.HiltViewModel
56
import kotlinx.coroutines.CoroutineDispatcher
67
import org.wordpress.android.modules.UI_THREAD
78
import org.wordpress.android.ui.accounts.LoginNavigationEvents
@@ -12,6 +13,7 @@ import org.wordpress.android.viewmodel.ScopedViewModel
1213
import javax.inject.Inject
1314
import javax.inject.Named
1415

16+
@HiltViewModel
1517
class LoginSiteCheckErrorViewModel @Inject constructor(
1618
@Named(UI_THREAD) mainDispatcher: CoroutineDispatcher
1719
) : ScopedViewModel(mainDispatcher) {

0 commit comments

Comments
 (0)