Skip to content

Commit 17db38c

Browse files
committed
Remove optional params of android_build_prechecks
As those are all optional and all default to `false`. I've also made those calls on single line now that they are shorter, and added the `unless options[:skip_prechecks]`, to match the call site style we already used in the `build_beta` lane on line 67 See discussion with @ParaskP7 in #17046 (comment)
1 parent 0457096 commit 17db38c

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

fastlane/lanes/build.rb

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,7 @@
1515
#####################################################################################
1616
desc 'Builds and updates for distribution'
1717
lane :build_and_upload_release do |options|
18-
android_build_prechecks(
19-
skip_confirm: options[:skip_confirm],
20-
alpha: false,
21-
beta: false,
22-
final: true
23-
)
18+
android_build_prechecks(skip_confirm: options[:skip_confirm], final: true) unless options[:skip_prechecks]
2419
android_build_preflight() unless options[:skip_prechecks]
2520

2621
# Create the file names
@@ -48,12 +43,7 @@
4843
#####################################################################################
4944
desc 'Builds and updates for distribution'
5045
lane :build_and_upload_pre_releases do |options|
51-
android_build_prechecks(
52-
skip_confirm: options[:skip_confirm],
53-
alpha: false,
54-
beta: true,
55-
final: false
56-
)
46+
android_build_prechecks(skip_confirm: options[:skip_confirm], beta: true) unless options[:skip_prechecks]
5747
android_build_preflight() unless options[:skip_prechecks]
5848
app = get_app_name_option!(options)
5949
build_beta(app: app, skip_prechecks: true, skip_confirm: options[:skip_confirm], upload_to_play_store: true, create_release: options[:create_release])

0 commit comments

Comments
 (0)