Skip to content

Commit a89e685

Browse files
authored
Merge pull request #8831 from iangmaia/cleanup/deprecate-deliver-file
Deprecate `Deliverfile` in favor of `Fastfile`
2 parents 0db1066 + fb64010 commit a89e685

File tree

2 files changed

+27
-31
lines changed

2 files changed

+27
-31
lines changed

fastlane/Deliverfile

Lines changed: 0 additions & 30 deletions
This file was deleted.

fastlane/Fastfile

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ platform :ios do
172172
lane :code_freeze do |options|
173173
ios_codefreeze_prechecks(options)
174174

175-
ios_bump_version_release(skip_glotpress: true)
175+
ios_bump_version_release(skip_glotpress: true, skip_deliver: true)
176176
new_version = ios_get_app_version
177177
extract_release_notes_for_version(
178178
version: new_version,
@@ -585,6 +585,32 @@ platform :ios do
585585
)
586586
end
587587

588+
# Upload the localized metadata (from `fastlane/metadata/`) to App Store Connect
589+
#
590+
# @option [Boolean] with_screenshots (default: false) If true, will also upload the latest screenshot files to ASC
591+
#
592+
desc 'Upload the localized metadata to App Store Connect, optionally including screenshots.'
593+
lane :update_metadata_on_app_store_connect do |options|
594+
# Skip screenshots by default. The naming is "with" to make it clear that
595+
# callers need to opt-in to adding screenshots. The naming of the deliver
596+
# (upload_to_app_store) parameter, on the other hand, uses the skip verb.
597+
with_screenshots = options.fetch(:with_screenshots, false)
598+
skip_screenshots = !with_screenshots
599+
600+
upload_to_app_store(
601+
app_identifier: APP_STORE_VERSION_BUNDLE_IDENTIFIER,
602+
app_version: ios_get_app_version,
603+
team_id: '299112',
604+
skip_binary_upload: true,
605+
screenshots_path: File.join(FASTLANE_DIR, 'promo_screenshots'),
606+
skip_screenshots: skip_screenshots,
607+
overwrite_screenshots: true, # won't have effect if `skip_screenshots` is true
608+
phased_release: true,
609+
precheck_include_in_app_purchases: false,
610+
api_key_path: ASC_KEY_PATH
611+
)
612+
end
613+
588614
#####################################################################################
589615
# register_new_device
590616
# -----------------------------------------------------------------------------------

0 commit comments

Comments
 (0)