Skip to content

Fatal error in action causes shutdown to run with wrong/overwritten error handler #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkmuffme opened this issue Mar 27, 2025 · 0 comments · May be fixed by #1254
Open

Fatal error in action causes shutdown to run with wrong/overwritten error handler #1253

kkmuffme opened this issue Mar 27, 2025 · 0 comments · May be fixed by #1254

Comments

@kkmuffme
Copy link

If an action has a fatal the "finally" with "restore_error_handler"

never runs.

This means that on shutdown the overwritten error handler is used, which throws - however since it's not in a try/catch block anymore now, this will fatal (= call the exception handler and exit)

kkmuffme added a commit to kkmuffme/action-scheduler that referenced this issue Mar 27, 2025
@kkmuffme kkmuffme linked a pull request Mar 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant