Skip to content

Investigate if the error handling in the action processor can be simplified #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coreymckrill opened this issue Mar 15, 2025 · 0 comments
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@coreymckrill
Copy link
Contributor

Part of the problem in #1245 was due to a try/catch block that intercepts all throwables (which, in modern versions of PHP includes things like fatal errors for calling undefined functions) but then doesn't always handle them in a way that's useful for debugging. In another discussion elsewhere, it was explained like this:

...the overly complex error handling structure we have in place (a custom error handler, followed by a try/catch inside a try/catch/finally) may not be needed any longer. This was always a bit convoluted, but existed partly because we were trying to handle a very wide range of PHP versions, with some massive differences in terms of which errors were throwable and which were not. Since that was introduced, though, we have subsequently dropped support for PHP 5.6 ... so it may be viable to drastically simplify it now.

We should investigate whether this is indeed viable, and simplify it if we can. Our future selves will thank us.

@coreymckrill coreymckrill added the type: task The issue is an internally driven task (e.g. from another A8c team). label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

1 participant