Skip to content

A couple bugs with getModel() method #73

@jacobg

Description

@jacobg

In getModel() method:

  1. The call to Ext.ModelManager.get should be Ext.ModelManager.getModel.

  2. It defines SlideNavigationPanelItem model class as a global variable via Ext.define. That is bad practice to pollute the global namespace. A better way to set the model name would be like this:

var className = this.self.getName(),
    model = className.substr(0, className.lastIndexOf('.')) + '.SlideNavigationPanelItem';

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions