-
Notifications
You must be signed in to change notification settings - Fork 54
Description
Describe the Bug
The current implementation expects a lot of endpoints to return HTTP 200 with data {"success": true}, but Tado dropped that and returns an empty response instead:
Example API response mytado:
PUT https://my.tado.com/api/v2/homes/123456/zones/1/openWindowDetection
Payload: (as usual)
Response: HTTP 204
Example API response hops:
PUT https://hops.tado.com/homes/1234567/settings/owd/rooms/1
Payload: (as usual)
Response: HTTP 204
This causes the model validation logic for SuccessResult to fail.
Environment
Provide details about your environment where the bug occurred:
- PyTado Version:
11db6dc
I'm happy to provide a PR. Would you still be open to merge it even though you're stepping back?
Do you see any reason to continue support the HTTP 200 {"success": true} response? As far as I can see, this is not used by Tado anymore.