Skip to content

Commit b4de5ad

Browse files
author
imankitsingh
committed
Minor fixes, added 15 min start delay in delete marked file job.
1 parent 8f07168 commit b4de5ad

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

grails-app/jobs/com/wizpanda/file/DeleteMarkedFileJob.groovy

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ package com.wizpanda.file
44
* Job to delete marked stored files from S3.
55
*
66
* @author Ankit Kumar Singh
7-
* @since 1.0.3
7+
* @since 0.1.3
88
*/
99
class DeleteMarkedFileJob {
1010

1111
FileDeletionService fileDeletionService
1212

13+
def concurrent = false
14+
1315
static triggers = {
14-
simple repeatInterval: 1000l * 60 * 60 * 2 // execute job once in 2 hour
16+
simple startDelay: 1000l * 60 * 15, repeatInterval: 1000l * 60 * 60 * 2 // execute job once in 2 hour
1517
}
1618

1719
def execute() {

grails-app/services/com/wizpanda/file/FileDeletionService.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import groovy.time.TimeCategory
88
* Service class to perform delete operations on file which are marked for deletion.
99
*
1010
* @author Ankit Kumar Singh
11-
* @since 1.0.3
11+
* @since 0.1.3
1212
*/
1313
@Transactional
1414
class FileDeletionService {
@@ -31,7 +31,7 @@ class FileDeletionService {
3131
isNotNull("markedForDeletion")
3232
le("markedForDeletion", dateForDeletion)
3333

34-
maxResult(MAX)
34+
maxResults(MAX)
3535
}
3636

3737
storedFileList.each { StoredFile storedFile ->

src/test/groovy/com/wizpanda/file/FileDeletionServiceSpec.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package com.wizpanda.file
33
import grails.testing.services.ServiceUnitTest
44
import spock.lang.Specification
55

6-
class FileDeletionServiceSpec extends Specification implements ServiceUnitTest<FileDeletionService>{
6+
class FileDeletionServiceSpec extends Specification implements ServiceUnitTest<FileDeletionService> {
77

88
def setup() {
99
}
@@ -12,7 +12,7 @@ class FileDeletionServiceSpec extends Specification implements ServiceUnitTest<F
1212
}
1313

1414
void "test something"() {
15-
expect:"fix me"
16-
true == false
15+
expect: "fix me"
16+
true == false
1717
}
1818
}

0 commit comments

Comments
 (0)