-
What version of
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 2 replies
-
|
See PR #3116 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the suggestion and the PR @awhitford! I’m not sure this is needed to achieve what you describe? It’s already valid to do: ---
import Default from '@astrojs/starlight/components/Footer.astro';
---
<Default />
<div class="github">
<!-- additional UI -->
</div>The issue with doing this via a I think our documented pattern of placing additional UI before/after the default component is sufficient. And if someone needs a more finegrained positioning, then they can e.g. use that same approach but with a pagination override. That keeps the model simple and consistent: you can place custom content either side of any component, but not also slot it somewhere. |
Beta Was this translation helpful? Give feedback.
-
|
You make a good point. I think I was distracted by how Orama unnecessarily duplicated the code. My only other thought is that semantically, if the |
Beta Was this translation helpful? Give feedback.
-
Yes, that’s a reasonable desire, but to achieve what #3116 allows is still possible, you just override ---
import Default from '@astrojs/starlight/components/Pagination.astro';
---
<Default />
<div class="github">
<!-- additional UI -->
</div> |
Beta Was this translation helpful? Give feedback.
Thanks for the suggestion and the PR @awhitford!
I’m not sure this is needed to achieve what you describe? It’s already valid to do:
The issue with doing this via a
<slot />is that it requires deciding where in the footer to place that extra content. In your PR it’s between the pagination and credits components, but what if someone wants it at the top or below the credits? And it’s also additional documentation complexity: our other components don’t support this approach and we’d need to say how it behaved etc.I think our documented pattern of placi…